Remove USD as the default fiat currency by grunch · Pull Request #250 · MostroP2P/mobile

grunch · 2025-08-01T19:51:56Z

Changes Made:

Modified selectedFiatCodeProvider in lib/shared/providers/exchange_service_provider.dart to return String? instead of String and removed the ?? 'USD' fallback
Added localization keys in all ARB files (en/es/it):

"selectCurrency" - "Select Currency" / "Seleccionar Moneda" / "Seleziona Valuta"
"noCurrencySelected" - "No currency selected" / "Ninguna moneda seleccionada" / "Nessuna valuta selezionata"

Updated UI components to handle null currency selection:

currency_section.dart - Shows "Select Currency" when no currency is selected
settings_screen.dart - Shows "No currency selected" in settings when none chosen
add_order_screen.dart - Properly validates non-null currency before order submission
payment_methods_section.dart - Handles null currency code gracefully

Fixed all Flutter analyzer issues - Zero warnings or errors remain

Now when the app is first installed, users will see "Select Currency" instead of USD, and they must explicitly choose a fiat currency before they can create orders. The selected currency persists in settings once chosen.

Summary by CodeRabbit

New Features
- Added new localized strings for currency selection in English, Spanish, and Italian.
Bug Fixes
- Improved handling of currency selection by resetting to the default fiat currency for each new order.
- Enhanced validation to prevent issues when no currency is selected.
- Updated UI to display appropriate messages when no currency is selected.
Style
- Improved display text and fallback messaging for currency selection fields.

Changes Made: 1. Modified selectedFiatCodeProvider in lib/shared/providers/exchange_service_provider.dart to return String? instead of String and removed the ?? 'USD' fallback 2. Added localization keys in all ARB files (en/es/it): - "selectCurrency" - "Select Currency" / "Seleccionar Moneda" / "Seleziona Valuta" - "noCurrencySelected" - "No currency selected" / "Ninguna moneda seleccionada" / "Nessuna valuta selezionata" 3. Updated UI components to handle null currency selection: - currency_section.dart - Shows "Select Currency" when no currency is selected - settings_screen.dart - Shows "No currency selected" in settings when none chosen - add_order_screen.dart - Properly validates non-null currency before order submission - payment_methods_section.dart - Handles null currency code gracefully 4. Fixed all Flutter analyzer issues - Zero warnings or errors remain Now when the app is first installed, users will see "Select Currency" instead of USD, and they must explicitly choose a fiat currency before they can create orders. The selected currency persists in settings once chosen.

coderabbitai · 2025-08-01T19:52:02Z

Caution

Review failed

The pull request is closed.

Walkthrough

This update refactors fiat currency selection and state management in the order and settings flows. It makes the fiat code provider nullable, resets it to the default on order screen initialization, improves null handling in UI and validation, and adds new localization strings for currency selection prompts in English, Spanish, and Italian.

Changes

Cohort / File(s)	Change Summary
Order Screen Fiat Code Management `lib/features/order/screens/add_order_screen.dart`	Resets `selectedFiatCodeProvider` to default fiat from settings on screen init; improves null validation and variable assignment for fiat code in order submission.
Currency Section UI & Logic `lib/features/order/widgets/currency_section.dart`	Removes settings provider import; handles null `selectedFiatCode` with fallback text; updates key and UI display logic; removes updating settings on selection.
Payment Methods Section `lib/features/order/widgets/payment_methods_section.dart`	Ensures localization method always receives a non-null string for fiat code by using a null-aware operator.
Settings Screen Currency Selector `lib/features/settings/settings_screen.dart`	Now derives selected fiat code from settings provider, not fiat code provider; adds fallback text for null selection.
Localization Additions (EN, ES, IT) `lib/l10n/intl_en.arb`, `lib/l10n/intl_es.arb`, `lib/l10n/intl_it.arb`	Moves "selectCurrency" string and adds "noCurrencySelected" string in English, Spanish, and Italian localization files.
Exchange Service Provider Refactor `lib/shared/providers/exchange_service_provider.dart`	Removes settings provider import; changes `selectedFiatCodeProvider` to nullable and initializes to `null` instead of a default.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AddOrderScreen
    participant SettingsProvider
    participant selectedFiatCodeProvider

    User->>AddOrderScreen: Navigates to Add Order
    AddOrderScreen->>SettingsProvider: Fetch defaultFiatCode
    AddOrderScreen->>selectedFiatCodeProvider: Reset to defaultFiatCode
    User->>AddOrderScreen: Fills order form, submits
    AddOrderScreen->>selectedFiatCodeProvider: Read selectedFiatCode
    AddOrderScreen->>AddOrderScreen: Validate selectedFiatCode (null/empty)
    AddOrderScreen->>Order: Create order with fiatCode

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

Remove USD as the default fiat currency #250: Modifies selectedFiatCodeProvider state handling and UI updates related to fiat currency selection, overlapping changes in provider and null handling.
Fix currency selection dialog state management #222: Refactors currency selection UI and synchronizes selectedFiatCodeProvider with settings, directly modifying the same provider and state management logic as in this PR.

Suggested reviewers

AndreaDiazCorreia

Poem

A hop and a skip through the code we go,
Fiat codes now nullable, defaults in tow.
With "Select Currency" in every tongue,
The screens feel fresh, the UI’s young.
Rabbits rejoice—no more nulls to fear,
Currency selection is crystal clear! 🐇💱

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 873bac0 and 01cbee7.

📒 Files selected for processing (3)

lib/l10n/intl_en.arb (1 hunks)
lib/l10n/intl_es.arb (1 hunks)
lib/l10n/intl_it.arb (1 hunks)

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/remove-usd-default-currency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6b682e and 873bac0.

📒 Files selected for processing (8)

lib/features/order/screens/add_order_screen.dart (5 hunks)
lib/features/order/widgets/currency_section.dart (2 hunks)
lib/features/order/widgets/payment_methods_section.dart (1 hunks)
lib/features/settings/settings_screen.dart (2 hunks)
lib/l10n/intl_en.arb (1 hunks)
lib/l10n/intl_es.arb (1 hunks)
lib/l10n/intl_it.arb (1 hunks)
lib/shared/providers/exchange_service_provider.dart (1 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

lib/l10n/*.arb