fix: cannot find stable release#355
Conversation
|
This a fascinating and weird bug, looks good to me. |
|
Hello. Are you sure this is a proper fix? I get this right now |
bob v4.1.5 has a bug where `bob update` fails with "Cannot find stable release" error. Since we only use nightly, explicitly specify nightly to avoid this issue. See: MordechaiHadad/bob#355
bob v4.1.5 has a bug where `bob update` fails with "Cannot find stable release" error. Since we only use nightly, explicitly specify nightly to avoid this issue. See: MordechaiHadad/bob#355
|
This PR apparently didn't fix the issue as people still get the error even on latest bob. I'm including myself in "people". |
|
I don't know if this horse is dead, and I'm just kicking it; but I'll also assert we need a different fix. The main issue is that there is no way to know how many items need to be in a page in order to go back far enough to get all the releases we need. If there are more than Then if we want other releases, too, we can do a separate call to get them. Alternatively we could just get more pages from the existing URL until we get to the stable release. Thoughts? |
|
@huntwj - temp fix in #360 and refactor proposed, and currently being worked on via Given consistent requests, I'm also going to further open discussion in 348 regarding the ability to use the archive repo that the Neovim org maintains as a host address (for distros that use much older glibc versions for instance) |
Summary :
refs: https://github.com/MordechaiHadad/bob/blob/master/src/helpers/version/mod.rs#L285
stabletag name by making a GET request to the urlhttps://api.github.com/repos/neovim/neovim/releases?per_page=10, but it couldn't find thestabletag name from the response contents. so it gives a errorCannot find stable releaseper_pageparam from10to15, it is able to find thestablerelease.here are some pics of making a GET request to the url
https://api.github.com/repos/neovim/neovim/releases?per_page=15and greping thestablerelease in the response contents.TL;DR
per_pagecount from10to15.cc @MordechaiHadad