fix(#324): Handle Env. Var starting $ sign#328
Merged
Conversation
Contributor
Author
|
@MordechaiHadad - Please merge this ASAP as it's a critical oversight on my original PR and is preventing users from using updated, stable versions (ie: Master/releases) of the software. |
$ sign$ sign
Fixes a regression introduced in #d6813be8 where the change from using `.capture().unwrap().get(1)` would already omit the `$` sign. This resolves this by doing an in-place truncation and dropping the `$` sign for matching purposes.
e8b6b3d to
a9ecbc4
Compare
Contributor
Author
|
I can rebase this PR over the top of #322 if you'd like - May be easier if you're also planning merging it as well, would then be a clean merge of 322 -> master, 328 (this one) -> master one after the other. |
MrDwarf7
pushed a commit
to MrDwarf7/bob
that referenced
this pull request
Sep 29, 2025
fix(MordechaiHadad#324): Handle Env. Var starting `$` sign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #d6813be8 and highlighted as a critical issue in #324
Where the change from using
.capture().unwrap().get(1)would already omit the$sign.This resolves this by doing an in-place truncation and dropping the
$sign for matching purposes.