Skip to content

Add support for completions in Nushell#320

Merged
MordechaiHadad merged 3 commits into
MordechaiHadad:masterfrom
kaasboteram:master
Oct 13, 2025
Merged

Add support for completions in Nushell#320
MordechaiHadad merged 3 commits into
MordechaiHadad:masterfrom
kaasboteram:master

Conversation

@kaasboteram

Copy link
Copy Markdown
Contributor

No description provided.

@MordechaiHadad MordechaiHadad linked an issue Sep 5, 2025 that may be closed by this pull request
@MordechaiHadad

Copy link
Copy Markdown
Owner

LGTM! Although I see that 'clap_complete_nushell` by nibon7 is archived, is the crate in in the TOML pointing to https://github.com/clap-rs/clap/tree/master/clap_complete_nushell instead?

@antoineeestevaaan antoineeestevaaan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change line 164 of the README from

- `bob complete bash|elvish|fish|powershell|zsh`

to

- `bob complete bash|elvish|fish|powershell|zsh|nu`

?

@kaasboteram

Copy link
Copy Markdown
Contributor Author

LGTM! Although I see that 'clap_complete_nushell` by nibon7 is archived, is the crate in in the TOML pointing to https://github.com/clap-rs/clap/tree/master/clap_complete_nushell instead?

The clap_complete_nushell page on crates.io says the repo to be clap-rs/clap. So I think the version on the crate registry is the maintained one

@MordechaiHadad

Copy link
Copy Markdown
Owner

OI @CodingCat12 please fix those clippy errors and i shall merge.

@kaasboteram

Copy link
Copy Markdown
Contributor Author

Can you help me figure out this issue? I'm not familiar with the pipeline, the error says it can't install clippy, but I don't understand how my changes could have caused that. Can you help me understand the issue please?

@MordechaiHadad

Copy link
Copy Markdown
Owner

Huh, I just read the actual error now that you mentioned it.
That is mad odd, and you are right your changes shouldn't be the reason it fails.
Will look into it and let you know.

@MrDwarf7

Copy link
Copy Markdown
Contributor

@MordechaiHadad and @CodingCat12 -

Can't definitively say why it's playing up but I did find this which specifies the minimal profile only contains support for rustc, rust-std and cargo itself.

Which is what's being used here and throughout which may explain the CI failures.

@MordechaiHadad

Copy link
Copy Markdown
Owner

@CodingCat12 could you submit a new empty commit to restart the CI workflow? I think it should just work on a restart or something.

@MrDwarf7

Copy link
Copy Markdown
Contributor

Could either mark it with an ignore (though not sure if DeepSource cares about linting ignores) or use Pwsh to get it passing CI @CodingCat12

@MordechaiHadad

Copy link
Copy Markdown
Owner

okay i was correct, it seems like github actions sometimes kills itself so it needs restarts.

@MordechaiHadad MordechaiHadad merged commit 26760be into MordechaiHadad:master Oct 13, 2025
20 of 21 checks passed
MrDwarf7 pushed a commit to MrDwarf7/bob that referenced this pull request Oct 13, 2025
Add support for completions in Nushell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nushell completition

4 participants