Platform upgrade - align with upstream platformio.ini #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* espressif32@5.2.0 --> espressif32@5.3.0 * pxmagic.htm added in cdata.js * minor updates in style.css * align some constants and definitions (wled.h, const.h) * npm run build
this is to prevent that an "old" packet with high sequence number (before counter roll-over) gets accepted wrongly.
NTP validation, and rejecting malformed responses (related to wled#3515)
removed bugfixes/changes for code not present in WLEDMM
Collaborator
|
Reviewed and tested espressif32@5.3.0 with an S3 board - seems fine to me. I have noticed some issues with espressif32@6.4.0 - but nothing like that with 5.3.0 |
Collaborator
Author
|
Ok then lets do it. Thanks for the quick check 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@netmindz, @ewoudwijma, @troyhacks please test this change on your favourite devices, to make sure there are no hidden "showstoppers" for main MM usecases.