receiveAudioData() process latest packet only #231
Conversation
|
Warning Rate limit exceeded@troyhacks has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 6 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @troyhacks, guess I'll need to double-check your commit, as it seems to remove some of the "flush buffer for unknown packets" safety code. Also you removed some of my code comments, and I don't understand yet whats the reason, (just a note to myself, nothing to do from your side 😃) |
| size_t lastValidPacketSize = 0; | ||
|
|
||
| // Loop to read all available packets | ||
| while (true) { |
There was a problem hiding this comment.
basicially yes, but this "read all packets" should only be conditionally.
- user option
- or automatically in special cases: newly activated(drops junk), delay since last read > 200ms (OS hickup), when silence detected (jumps not visible), etc.
if we do it unconditionally, this might cause visible jumping on WiFi connections, because wifi is allowed to deliver UDP packets in bursts.
* rework of PR #231 * allow droping packets when - first connection - silence - re-connect after timeout - main loop is too slow
Quickly picks only the latest received UDP audio packet from the buffer to ensure we have the most recent audio data available.
This reduces the "buffer impact" if a board has buffered many audio packets, and effects continue to be audio responsive even after the live audio has stopped.