Skip to content

Add Buttons.None#7818

Merged
ThomasFOG merged 2 commits intoMonoGame:developfrom
TimerbaevRR:add_buttons_none
Jun 14, 2022
Merged

Add Buttons.None#7818
ThomasFOG merged 2 commits intoMonoGame:developfrom
TimerbaevRR:add_buttons_none

Conversation

@TimerbaevRR
Copy link
Copy Markdown
Contributor

@TimerbaevRR TimerbaevRR commented Jun 10, 2022 •
edited
Loading

@TimerbaevRR
Copy link
Copy Markdown
Contributor Author

TimerbaevRR commented Jun 10, 2022

Fixes #7634

@TimerbaevRR TimerbaevRR marked this pull request as ready for review June 13, 2022 17:52
@ThomasFOG ThomasFOG merged commit 3954144 into MonoGame:develop Jun 14, 2022
@ThomasFOG
Copy link
Copy Markdown
Contributor

ThomasFOG commented Jun 14, 2022

Thanks!

@BaseCrosser
Copy link
Copy Markdown

BaseCrosser commented Jun 21, 2022

About 6 years ago I also tried to add a Buttons.None. #4618
Doing this comes with some problems.

As was said back then the GamePad.GetState().IsButtonDown implementation is doing a bitwise & comparison between the pressed buttons and the parameter, but Anything & 0 returns 0, and 0 == 0 is always true
https://github.com/MonoGame/MonoGame/blob/develop/MonoGame.Framework/Input/GamePadState.cs#L138

With this implementation of adding Buttons.None and setting its value to 0 the result of querying GamePad.GetState().IsButtonDown(Buttons.None) would always return true.

@TimerbaevRR
Copy link
Copy Markdown
Contributor Author

TimerbaevRR commented Jun 21, 2022

@mrhelmut Maybe should we revert this PR?
I will try to fix problems and create new PR

@ThomasFOG
Copy link
Copy Markdown
Contributor

ThomasFOG commented Jun 21, 2022

I don't feel like there is a need to revert this PR, it doesn't seem to cause any harm.

We should be fine with a if (button == Buttons.None) return false in IsButtonDown().

@ThomasFOG ThomasFOG mentioned this pull request Jun 22, 2022
Merged
@ThomasFOG
Copy link
Copy Markdown
Contributor

ThomasFOG commented Jun 22, 2022

I went ahead because the test were failing because of this and I'm looking into restoring them: #7822

viniciusjarina pushed a commit to codefoco/MonoGame that referenced this pull request Jul 4, 2022
@TimerbaevRR @lx13s @viniciusjarina
Add Buttons.None (MonoGame#7818)
4fcd7a0 
* Added Buttons.None MonoGame#7634

* comment fix

Co-authored-by: Rust <savage@speccy.su>
bytinggames pushed a commit to bytinggames/MonoGame that referenced this pull request Oct 9, 2022
@TimerbaevRR @lx13s @bytinggames
Add Buttons.None (MonoGame#7818)
264a7ce 
* Added Buttons.None MonoGame#7634

* comment fix

Co-authored-by: Rust <savage@speccy.su>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TimerbaevRR @ThomasFOG @BaseCrosser @lx13s