Skip to content

Added RollForward directive#7789

Merged
harry-cpp merged 2 commits intoMonoGame:developfrom
FlyingOakGames:roll
May 5, 2022
Merged

Added RollForward directive#7789
harry-cpp merged 2 commits intoMonoGame:developfrom
FlyingOakGames:roll

Conversation

@ThomasFOG
Copy link
Copy Markdown
Contributor

I went ahead and moved #7574 forward across all the repository so that people coming from the future won't have questions in regard to requirements.

@harry-cpp
Copy link
Copy Markdown
Member

If I understood it correctly, RollForward should only be added to projects that produce an executable.

https://docs.microsoft.com/en-us/dotnet/core/versions/selection#framework-dependent-apps-roll-forward

@ThomasFOG
Copy link
Copy Markdown
Contributor Author

Updated!

@harry-cpp harry-cpp merged commit 74aca42 into MonoGame:develop May 5, 2022
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net6.0-android</TargetFramework>
<RollForward>Major</RollForward>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post merge regrets, iOS and Android aren't supposed to have it, there is no point for them 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to push a clean up PR.

bytinggames pushed a commit to bytinggames/MonoGame that referenced this pull request Oct 9, 2022
* Added RollForward directive

* Removed rollforward from libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants