Skip to content

Update mgfxc_wine_setup.sh#7327

Merged
harry-cpp merged 2 commits intoMonoGame:developfrom
Kwyrky:patch-1
Aug 23, 2020
Merged

Update mgfxc_wine_setup.sh#7327
harry-cpp merged 2 commits intoMonoGame:developfrom
Kwyrky:patch-1

Conversation

@Kwyrky
Copy link
Copy Markdown
Contributor

@Kwyrky Kwyrky commented Aug 22, 2020

Make sure we don't mess up .profile / .zprofile files which could have text or commands in the last line. In this case the export command would be appended directly to the last command and not end up in its own line.

Make sure we don't mess up .profile / .zprofile files which could have text or commands in the last line. In this case the export command would be appended directly to the last command and not end up in its own line.
Copy link
Copy Markdown
Member

@harry-cpp harry-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed >> will add stuff to the new line.

@harry-cpp
Copy link
Copy Markdown
Member

Oh wait, it only adds the new line after the line, anyhow modify to use -e flag, it will look nicer.

@Kwyrky
Copy link
Copy Markdown
Contributor Author

Kwyrky commented Aug 23, 2020

I added the -e flag as the change request suggested.

@Kwyrky Kwyrky closed this Aug 23, 2020
@Kwyrky Kwyrky reopened this Aug 23, 2020
@Kwyrky Kwyrky mentioned this pull request Aug 23, 2020
@harry-cpp harry-cpp merged commit 3aed7d5 into MonoGame:develop Aug 23, 2020
@harry-cpp
Copy link
Copy Markdown
Member

Thanks @Kwyrky, merging!

@harry-cpp
Copy link
Copy Markdown
Member

On a random note, did you know that a text file without a new line character at the end is technically invalid on Unix :)

@Kwyrky
Copy link
Copy Markdown
Contributor Author

Kwyrky commented Aug 23, 2020

Nice, thanks for merging! That is what I assumed and wrote I think in the community forums ^^

@Kwyrky Kwyrky deleted the patch-1 branch August 23, 2020 18:33
nkast pushed a commit to nkast/MonoGame that referenced this pull request Sep 10, 2020
Ensure that env variables always get added to the new line
kimimaru4000 pushed a commit to kimimaru4000/MonoGame that referenced this pull request Sep 25, 2020
Ensure that env variables always get added to the new line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants