Skip to content

Template fix for DX platform, adds "UseWindowsForms" to the DX csproj#7289

Merged
harry-cpp merged 1 commit intoMonoGame:developfrom
SimonDarksideJ:fix/usewpf_dx
Aug 10, 2020
Merged

Template fix for DX platform, adds "UseWindowsForms" to the DX csproj#7289
harry-cpp merged 1 commit intoMonoGame:developfrom
SimonDarksideJ:fix/usewpf_dx

Conversation

@SimonDarksideJ
Copy link
Copy Markdown
Contributor

@SimonDarksideJ SimonDarksideJ commented Aug 10, 2020

Updated DX template to include the "UseWindowsForms" tag, else this causes the error reported in #7238

Although this (maybe others) template needs checking against any other changes made to the csproj in the Framework.

Template

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <PublishReadyToRun>false</PublishReadyToRun>
    <TieredCompilation>false</TieredCompilation>
    <UseWindowsForms>true</UseWindowsForms>
  </PropertyGroup>

Framework csproj

  <PropertyGroup>
    <TargetFrameworks>net452;netcoreapp3.1</TargetFrameworks>
    <DefineConstants>WINDOWS;XNADESIGNPROVIDED;STBSHARP_INTERNAL</DefineConstants>
    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
    <UseWindowsForms>true</UseWindowsForms>
    <Description>The MonoGame runtime for Windows using DirectX API's.</Description>
    <PackageTags>monogame;.net core;core;.net standard;standard;windowsdx</PackageTags>
    <PackageId>MonoGame.Framework.WindowsDX</PackageId>
  </PropertyGroup>

Granted some tags are only added for NuGet package reference.

@tomspilman
Copy link
Copy Markdown
Member

tomspilman commented Aug 10, 2020

Leaving this for @Jjagg @harry-cpp as i don't know the issue well enough.

@tomspilman tomspilman mentioned this pull request Aug 10, 2020
Merged
@harry-cpp harry-cpp merged commit c69f8b0 into MonoGame:develop Aug 10, 2020
@SimonDarksideJ SimonDarksideJ deleted the fix/usewpf_dx branch August 10, 2020 08:47
kimimaru4000 pushed a commit to kimimaru4000/MonoGame that referenced this pull request Sep 25, 2020
@SimonDarksideJ @kimimaru4000
[Templates] Fix missing UseWindowsForms in mgwindows template (fixes M…
abf5138 
…onoGame#7289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonDarksideJ @tomspilman @harry-cpp