Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

Add proper pl language#316

Closed
Daxxxis wants to merge 10 commits intoModernFlyouts-Community:mainfrom
Daxxxis:language-pl
Closed

Add proper pl language#316
Daxxxis wants to merge 10 commits intoModernFlyouts-Community:mainfrom
Daxxxis:language-pl

Conversation

@Daxxxis
Copy link
Copy Markdown
Contributor

@Daxxxis Daxxxis commented Dec 18, 2020

No description provided.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 18, 2020

Ready to merge

Renzo904
Renzo904 reviewed Dec 18, 2020
View reviewed changes
ModernFlyouts/Properties/Strings.resx Outdated
</data>
<data name="About.FileABug" xml:space="preserve">
<value>If you find any bugs, please open a new issue in the github repository.</value>
<value>Jeśli znajdziesz jakieś błędy, otwórz nowe issue w repozytorium aplikacji w serwisie GitHub.</value>
Copy link
Copy Markdown
Contributor

@Renzo904 Renzo904 Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldnt be in english? since its in the original Strings(I messed up with the previous review and i didnt want to do it,sry)

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 18, 2020

@Renzo904 Fixed

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 18, 2020

Everything is ok now

@Samuel12321 Samuel12321 self-assigned this Dec 20, 2020
@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Dec 20, 2020

Thanks so much for your help, this will be added to 0.9

@Samuel12321 Samuel12321 added this to the 0.9 milestone Dec 20, 2020
@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 20, 2020 •
edited
Loading

Nope they accidentally modified Strings.resx and didn't remove unused resources from Strings.pl.resx.

Both of them are out of sync.

Shouldn't translators work on the *.xlf files?

Why do people always translate the *.resx files?

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 20, 2020 •
edited
Loading

They removed used resources Nevermind those are in the bottom and kept unused resources.

This will be bad for you @Samuel12321.

If we merge this, we would need another person to correct it again.

@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Dec 20, 2020

haven't actually reviewed it yet, just added it to the 0.9 release

@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Dec 20, 2020

Nope they accidentally modified Strings.resx and didn't remove unused resources from Strings.pl.resx.

Both of them are out of sync.

Shouldn't translators work on the *.xlf files?

Yes

Why do people always translate the *.resx files?

Dont know

@Samuel12321 Samuel12321 marked this pull request as draft December 20, 2020 05:34
@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Dec 20, 2020

They removed used resources Nevermind those are in the bottom and kept unused resources.

This will be bad for you @Samuel12321.

If we merge this, we would need another person to correct it again.

This wont be merged till i have reviewed it and checked it hasn't got an error.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 20, 2020 •
edited
Loading

I'm a bit lost. Do i need to do something?

@prakharb5
Copy link
Copy Markdown
Member

prakharb5 commented Dec 20, 2020

We can create a pull request template for translations telling to edit the xlf file and not the resx file.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 20, 2020 •
edited
Loading

@Cyberdroid1
Or just a link to wiki page with instructions in readme

@prakharb5
Copy link
Copy Markdown
Member

prakharb5 commented Dec 20, 2020

@Daxxxis
Our readme file is heavily cluttered as of now. Maintaining the template would be quite easier.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020

Do I need to move translations to xlf file?

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020

@Daxxxis,

It would be great if you do!

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020

@Daxxxis,

It would be great if you do!

Should I restore the original content of the resx file?

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020

@Daxxxis,

Yep! That's would be awesome!

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020

image
What's this?

@Daxxxis Daxxxis marked this pull request as ready for review December 21, 2020 12:38
@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020

@Daxxxis,

I really don't know.

And could you also revert changes to Strings.resx?

That's the only blocker.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020 •
edited
Loading

@Daxxxis,

I really don't know.

And could you also revert changes to Strings.resx?

That's the only blocker.

I have already done this
71b3eab

be525bf

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020

You accidentally removed "Flyout Modules" from Settings.Module in the Strings.resx.

That's the only issue pending.

Otherwise your contribution looks fantastic!

Thanks for understanding us and re-doing your work multiple times ❤️.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020

Fixed

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020

That's awesome!

@Samuel12321, merge this as soon as possible.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020

Btw, the current translation is a meme in our language lol

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020

What? 😂😂😂

Which one?

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020 •
edited
Loading

image

The word "wys" does not exist

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020 •
edited
Loading

Which one is the meme here?

I don't know polish 😅.

The "wysuwu"? uwu?

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020 •
edited
Loading

Or "wysuwu"
We took that as an ejecting sound lol

@ShankarBUS
Copy link
Copy Markdown
Member

ShankarBUS commented Dec 21, 2020

UWU???

😂😂😂

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Dec 21, 2020 •
edited
Loading

wys wys
Enter this 10 times in the translator and click play
Sounds like some fake shots

@prakharb5
Copy link
Copy Markdown
Member

prakharb5 commented Dec 21, 2020 •
edited
Loading

wys wys
Enter this 10 times in the translator and click play
Sounds like some fake shots

Just checked. Didn't disappoint me 😂😂

@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Jan 5, 2021

Hi @Daxxxis , thanks for your patience sorry for the delay in merging this, just waiting for the 0.9 release to be ready. Have found from experience that If I merge translations before the release is finalised they have an annoying habit of being over written, and I have to deal with people asking why there work was removed.

Sorry again for the delay, I expect this release will be finalised and these changes merged within the next few days.

@Daxxxis
Copy link
Copy Markdown
Contributor Author

Daxxxis commented Jan 5, 2021

Hi @Daxxxis , thanks for your patience sorry for the delay in merging this, just waiting for the 0.9 release to be ready. Have found from experience that If I merge translations before the release is finalised they have an annoying habit of being over written, and I have to deal with people asking why there work was removed.

Sorry again for the delay, I expect this release will be finalised and these changes merged within the next few days.

Ok, no problem 🙂

Samuel12321 pushed a commit that referenced this pull request Jan 18, 2021
Merged lanuage updates from: #363 , #356 #332 #331 #316
ca6ba70
@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Jan 18, 2021

Rebased and Merged with ca6ba70

@Daxxxis Daxxxis deleted the language-pl branch January 18, 2021 22:56
@prakharb5 prakharb5 added the Fixed Has been fixed. label Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Renzo904 Renzo904 Renzo904 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Samuel12321 Samuel12321

Labels

Fixed Has been fixed. Translation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Daxxxis @Samuel12321 @ShankarBUS @prakharb5 @Renzo904