Restore french translations#169
Restore french translations#169Samuel12321 merged 2 commits intoModernFlyouts-Community:mainfrom stlnb:main
Conversation
Because Visual Studio builds overrides .resx files Now with sorted .xlf translations + Added new strings + Sorted by name on original strings.resx
|
Also sorting the new strings in the base strings.resx file for readability. |
|
Thanks so much @Stealnoob, will merge this for the next release |
|
Merged, Thanks so much @Stealnoob |
|
Will be visible in 0.8.2 |
|
Wait, the merge commit broke both .resx files, and it doesn't even build (why do I have ocd of sorting things 🙃 ...) |
This reverts commit 57f41c1.
|
@Samuel12321, what is going on? This guy just did the PR two times and both of the times the translations are overwritten. This is why we should have a contribution guidelines document. Should contributors modify the *.xlf files or the *.resx files? |
|
@ShankarBUS there seems to be a problem preventing me and @Stealnoob building recently. This time the translations were applied correctly, i just reverted it to try to se if i could fix the problem. Will undo this revert once we fix the problem. |
|
@ShankarBUS @Samuel12321 |
|
yup, they are ridiculously helpful. |
And it's back another time.
@Samuel12321, I think I understand why translations are being reverted.
When building on Visual Studio, it builds the .resx files from the .xlf, so I think changes must be done to the .xlf files
For what I did : I translated the strings properly on the .resx, then deleted and recreated the .xlf from the Multilingual App Toolkit extension (it automatically imports from the localized .resx file), and manually validated review-requested strings (when source and target are the same) on the standalone editor, and I finally have something clean
So if there are translations added and if you want to apply them from one file to another, make sure you don't build the solution (and at least the ModernFlyouts C# project) before you have done the changes 🙂