Skip to content
This repository was archived by the owner on Nov 15, 2025. It is now read-only.

Requested Features - Personalisation#1217

Merged
Samuel12321 merged 23 commits intoModernFlyouts-Community:mainfrom
manstheram:main
Nov 11, 2024
Merged

Requested Features - Personalisation#1217
Samuel12321 merged 23 commits intoModernFlyouts-Community:mainfrom
manstheram:main

Conversation

@manstheram
Copy link
Copy Markdown
Contributor

@manstheram manstheram commented Aug 14, 2023 •
edited
Loading

This pull-request includes:

  • smaller lock flyouts in general (less space is wasted)
  • vertical volume bars
  • better inactive controls
  • fixed start-up task
  • and icon only lock flyouts.
    This is finished. @Samuel12321

@manstheram manstheram mentioned this pull request Aug 14, 2023
Closed
@Samuel12321 Samuel12321 self-requested a review August 15, 2023 09:49
@Samuel12321 Samuel12321 added this to the 0.10 milestone Aug 15, 2023
@Samuel12321 Samuel12321 linked an issue Aug 15, 2023 that may be closed by this pull request
Feature Request: Make "Lock Keys" alert UI smaller #593
Closed
@Samuel12321 Samuel12321 added the Enhancement New feature or request label Aug 15, 2023
@Samuel12321 Samuel12321 linked an issue Aug 15, 2023 that may be closed by this pull request
More customization for lock keys #1216
Closed
@manstheram manstheram marked this pull request as draft August 17, 2023 14:10
@manstheram manstheram changed the title Adds individual icons for lock keys Requested Features - Personalisation Aug 17, 2023
@manstheram manstheram mentioned this pull request Aug 18, 2023
Closed
@manstheram manstheram marked this pull request as ready for review August 18, 2023 21:03
@Samuel12321 Samuel12321 linked an issue Aug 18, 2023 that may be closed by this pull request
Vertical direction volume bar #1183
Closed
@Samuel12321
Copy link
Copy Markdown
Member

Samuel12321 commented Aug 18, 2023

Thanks @manstheram , will review test and merge this evening.

@manstheram
Copy link
Copy Markdown
Contributor Author

manstheram commented Aug 19, 2023 •
edited
Loading

I just noticed that the vertical volume bar setting doesn't save when you reopen the app, but the consise lock flyouts one does, so I gotta fix that.
Edit - Fixed that.

Samuel12321
Samuel12321 suggested changes Aug 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Samuel12321 Samuel12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manstheram , Thanks for the PR.
Just found a few issues that need to be resolved before merging.

  • Flyout axis setting is currently reversed
  • Lock icons are not following flyout theme, so are barely visible when flyout theme is dark.
  • Lock icons really need to be Segoe MDL2 or Segoe UI for consistency within both ModernFlyouts and Windows its self

Samuel12321
Samuel12321 reviewed Aug 20, 2023
View reviewed changes
Samuel12321
Samuel12321 reviewed Aug 20, 2023
View reviewed changes
@manstheram
Copy link
Copy Markdown
Contributor Author

manstheram commented Aug 20, 2023

Lock icons really need to be Segoe MDL2 or Segoe UI for consistency within both ModernFlyouts and Windows its self

About that, there are no lock icons for each type of lock in those fonts, which is why I had to use custom ones. ShankarBUS tried to do a similar thing, however he could only get blurry images since he was not using svgs - #63

But I can't create a neat icon. They looked blurry when scaled. WPF doesn't support SVGs. There were too many issues with this.
I guess just showing the lock icon will be enough for now

I got around the blurry state by using a converter "SvgtoXaml" to make svgs into shapes that I can use in WPF. https://github.com/BerndK/SvgToXaml

@manstheram
Lock keys colour update while app is running
3f55bbd 
The flyouts icon wouldn't update cause I used a resource file, so instead, I have all of them loaded as separate images in the UserControl where I needed to show them and then hide and show as required. Sure, it's messy, but that's cause .NET is bad.
@manstheram
Copy link
Copy Markdown
Contributor Author

manstheram commented Aug 20, 2023 •
edited
Loading

I have now added those first two changes you needed, but the third one can't be done cause there are no icons to use from those fonts. It should be finished now. @Samuel12321

manstheram
manstheram commented Aug 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@manstheram manstheram left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ready to use.

@manstheram manstheram closed this Aug 23, 2023
@manstheram manstheram reopened this Aug 23, 2023
@manstheram manstheram mentioned this pull request Aug 30, 2023
Open
@manstheram
Add compatibility mode for wrong min/max brightness
ce5924d 
Certain laptops are incorrectly reporting the min/max values they are capable of so I added a mode that just sets them to be 0 and 100 respectively.
@manstheram
To reset the min/max values
da4bc8e
@manstheram
Gap at bottom of session panel
b858898 
The minimum height didn't change depending on the top bar, now it does and aligns to the background of the session panel properly.
@manstheram
Cleanup and bigger size when no media session on
2c238a8
@manstheram
Avoid AudioFlyoutHelper not existing when registering events for Volu…
a0e8392 
…me Flyout
manstheram and others added 2 commits June 20, 2024 17:45
@manstheram
Merge branch 'ModernFlyouts-Community:main' into main
530a814
@manstheram
Correct the Version Check for Volume OSD
e752891 
For the 22H2 Volume OSD as I had incorrectly checked for 21H2 by accident.
@Samuel12321 Samuel12321 merged commit ea30f97 into ModernFlyouts-Community:main Nov 11, 2024
@Samuel12321 Samuel12321 mentioned this pull request Nov 11, 2024
Merged
Samuel12321 added a commit that referenced this pull request Nov 12, 2024
@Samuel12321
- Generated New Signing certificate
f2551ec 
- updated .net to 9 preview
- fixed crash on launch
- integrated fixes from #1217
- Updated Nuget Packages
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Samuel12321 Samuel12321 Awaiting requested review from Samuel12321

Assignees

@Samuel12321 Samuel12321

@manstheram manstheram

Labels

Enhancement New feature or request

Projects

None yet

Milestone

0.10

Development

Successfully merging this pull request may close these issues.

More customization for lock keys Vertical direction volume bar Feature Request: Make "Lock Keys" alert UI smaller

2 participants

@manstheram @Samuel12321