Skip to content

Do not store pointers to RANGE variable values#2

Merged
ramcdougal merged 1 commit into
masterfrom
olupton/no-range-ptrs
Apr 30, 2023
Merged

Do not store pointers to RANGE variable values#2
ramcdougal merged 1 commit into
masterfrom
olupton/no-range-ptrs

Conversation

@olupton

@olupton olupton commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

@olupton

olupton commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

@nrnhines are you OK with this solution to the problem described in the linked comments?

I think in this case then changing link to be a POINTER variable is not needed.

I believe similar fixes will be needed for models 7399, 9889, 12631 and 113732.

@nrnhines nrnhines left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olupton olupton force-pushed the olupton/no-range-ptrs branch from 37c5026 to 8d83e23 Compare April 20, 2023 15:19
@olupton olupton marked this pull request as ready for review April 20, 2023 15:20
@olupton olupton requested review from RuiLi7222 and ramcdougal April 20, 2023 19:56
@ramcdougal ramcdougal merged commit ca1e675 into master Apr 30, 2023
@ramcdougal ramcdougal deleted the olupton/no-range-ptrs branch April 30, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants