Fixing udp.d.ts #1487
Closed
Fixing udp.d.ts #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Yikes! You are correct that I think the implementations should be fixed. That will break some code. Best to do that sooner than later. For the transition, I can check for the first argument being a string and issue a specific exception about the needed change. |
mkellner
pushed a commit
that referenced
this pull request
May 13, 2025
Collaborator
|
Closing as the implementation has been updated to match the 419 specification and type declaration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an Error on the .d.ts file (Buffer should be the 3rd argument), refer to different native c code:
moddable/modules/io/socket/win/udp.c
Line 226 in 2945c5d
moddable/modules/io/socket/lin/udp.c
Line 233 in 2945c5d
moddable/modules/io/socket/lwip/udp.c
Line 197 in 2945c5d
moddable/modules/io/socket/mac/udp.m
Line 237 in 2945c5d