Skip to content

Add tests to MEOS#742

Merged
mschoema merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:meos_test
Nov 19, 2025
Merged

Add tests to MEOS#742
mschoema merged 1 commit intoMobilityDB:masterfrom
estebanzimanyi:meos_test

Conversation

@estebanzimanyi
Copy link
Copy Markdown
Member

  • Corrected memory leaks and memory errors using a set of programs in meos/test/*_test.c that call ALL the functions of the External MEOS API.
  • While doing this we improved the naming of a few MEOS functions.

@estebanzimanyi estebanzimanyi force-pushed the meos_test branch 7 times, most recently from 26bba33 to e7c7cd9 Compare November 6, 2025 17:02
@mschoema mschoema merged commit 0442dc0 into MobilityDB:master Nov 19, 2025
16 of 18 checks passed
@mschoema mschoema deleted the meos_test branch November 19, 2025 18:54
estebanzimanyi added a commit to estebanzimanyi/MobilityDB that referenced this pull request Apr 27, 2026
cppcheck flagged a possible null deref of inst2 at line 390. The early
'if (seq->count == 1) return NULL;' makes the loop run at least once
in the reachable path, so inst2 is set; the warning is a false positive
for cppcheck's analysis.

Refactor to drop the post-loop reference to inst2 entirely: after the
loop body, inst1 has been advanced to the same instant inst2 pointed
to (inst1 = inst2 at end of body), so use inst1->t for the final
timestamp. Move inst2 declaration into the loop where it's actually
written.

GHAS code-scanning alert MobilityDB#742 (PR MobilityDB#740 review) goes away with this.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants