Skip to content

Do not compile pg_bitutils.c as it's not needed and fails with mingw#610

Merged
mschoema merged 1 commit intoMobilityDB:masterfrom
mschoema:popcnt
Sep 27, 2024
Merged

Do not compile pg_bitutils.c as it's not needed and fails with mingw#610
mschoema merged 1 commit intoMobilityDB:masterfrom
mschoema:popcnt

Conversation

@mschoema
Copy link
Copy Markdown
Member

No description provided.

@mschoema
Copy link
Copy Markdown
Member Author

This should fix #609
Not sure what the problem was, but we are not using functions from pg_bitutils, so just don't compile it.

For documentation purposes in case we need pg_bitutils later:
The problem potentially comes from either HAVE_X86_64_POPCNTQ or HAVE__BUILTIN_POPCOUNT.
We hard-code HAVE__BUILTIN_POPCOUNT to 1 in pg_config.h.in instead of checking if it is available, so that might be the issue. Cmake detects that HAVE_X86_64_POPCNTQ should be false, so I don't think it is related to HAVE_X86_64_POPCNTQ, but I can't be sure.

From the Yggdrasil build process with mingw:

[13:47:02] -- Looking for __get_cpuid
[13:47:03] -- Looking for __get_cpuid - found
[13:47:03] -- Performing Test HAVE_X86_64_POPCNTQ
[13:47:03] -- Performing Test HAVE_X86_64_POPCNTQ - Failed

@mschoema mschoema merged commit d84e559 into MobilityDB:master Sep 27, 2024
@mschoema mschoema deleted the popcnt branch September 27, 2024 17:19
mschoema added a commit to mschoema/MobilityDB that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants