Ensure that required triangles are preserved#274
Merged
Algiane merged 2 commits intoMmgTools:developfrom Jul 22, 2024
Merged
Conversation
… preserved in the output
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
- Coverage 50.47% 50.45% -0.02%
===========================================
Files 174 176 +2
Lines 47158 47202 +44
Branches 10259 10263 +4
===========================================
+ Hits 23802 23818 +16
- Misses 15633 15652 +19
- Partials 7723 7732 +9 ☔ View full report in Codecov by Sentry. |
Algiane
reviewed
May 31, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Explanations of 1.
A bug was introduced by PR #239: triangles required by the user in the input mesh were not preserved anymore.
Indeed, in PR #239, if the face was not
MG_PARALLEL, then the tagsMG_REQ+MG_SURFwere removed, while onlyMG_SURFshould have been removed if the triangle was initially required by the user.Now, i.e. in this PR, the tag
MG_REQof edges is removed only if the edge isMG_PARALLELandMG_SURF.By convention in ParMmg (see tag_pmmg.c in ParMmg), if an entity is
MG_PARBDY+MG_NOSURF+MG_REQ;MG_PARBDY+MG_REQ;so we remove the tags
MG_NOSURFandMG_REQonly if the edge is effectivelyMG_PARALLELand identified asMG_NOSURF.