Fix tags on parallel interface when in LS discretization mode - for ParMmg#239
Merged
Algiane merged 2 commits intoMmgTools:developfrom Feb 8, 2024
Merged
Conversation
Algiane
reviewed
Jan 29, 2024
src/mmg3d/hash_3d.c
Outdated
| /* useful only when saving mesh or in ls mode */ | ||
| /* Useful only when saving mesh or in ls mode */ | ||
| for( j = 0; j < 3; j++ ) { | ||
| /* Assign tags to tria from xtetra->tag and remove redundant boundary tag */ |
Member
There was a problem hiding this comment.
I would add some additionnal comments to illustrate the issue we found when analysing for the second time the surface intersections in ParMmg :
/* Assign tags to tria from xtetra->tag and remove redundant boundary tag: when called from ParMmg in ls mode, it is needed to remove the parallel tags coming from previous surface analysis to ensure the suitable setting of the MG_BDY tag along edges at the intersection between geometrical (true) boundaries and purely parallel interfaces. For that, it is mandatory to remove the MG_PARBDYBDY tag already added along such edges (see the step 2 of the mmgHashTria implementation) */
laetitia-m
added a commit
to laetitia-m/mmg
that referenced
this pull request
May 29, 2024
… preserved in the output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ParMmg and in LS discretization mode, when we arrive for the second time in
MMG5_bdryTria, in the surface analysis,xtetra.tagexists andtria.tagis updated usingxtretravalues.In
MMG5_bdryTria, the edge tags of the triangle are assigned based on what is stored inxtetra.tag. However, in parallel, th edges should not inherit:(1) the tag
PARBDYBDYhere and(2) the tags
PARBDY,NOSURFandREQwhen we arrive from a non-parallel faces.The assignment of these appropriate tags is done later in
MMG5_mmgHashTria