Skip to content

Conversation

@fbsolo
Copy link
Contributor

@fbsolo fbsolo commented Apr 23, 2018

Text revisions to tighten and optimize the reading flow of the material.

Text revisions to tighten and optimize the reading flow of the material.
@PRMerger12
Copy link
Contributor

@fbsolo : Thanks for your contribution! The author, @edmacauley, has been notified to review your proposed change.

@edmacauley
Copy link
Contributor

Thank you for your contributions @fbsolo #sign-off

@v-shils v-shils merged commit 8a9aaf7 into MicrosoftDocs:live Apr 23, 2018
@fbsolo fbsolo deleted the patch-14 branch April 26, 2018 02:54
srutzky added a commit to srutzky/sql-docs that referenced this pull request Feb 27, 2019
…sql.md

1. Removed SQL Server version number from intro / summary. Behavior of this function does not vary between versions of SQL Server.

2. Improved wording of "LCID" definition: Defining LCID as LCID didn't give the reader any new information.

3. Improved wording of "Comparison" definition: A) Removed the word "case" (added by @fbsolo on 2018-04-23 via PR MicrosoftDocs#566 ) as it should not have been added. Properties cannot be case-sensitive. "Case" is a property that can be either sensitive or insensitive. B) added collation variations that have all sensitivities enabled. Unique variations for "everything-sensitive" collations found using the following query:

SELECT DISTINCT SUBSTRING(col.[name], PATINDEX(N'%[_][BC][IS]%', col.[name]), 100) AS [Sensitivities]
FROM   sys.fn_helpcollations() col
WHERE  CONVERT(INT, COLLATIONPROPERTY(col.[name], N'ComparisonStyle')) = 0
ORDER BY [Sensitivities];
/*
_BIN
_BIN2
_CS_AS_KS_WS
_CS_AS_KS_WS_SC
_CS_AS_KS_WS_VSS
*/

4. Improved wording of "Version" definition. The "derived from the collation ID version field" clause is awkward and has meaning to so few people that it really just confuses people. 

5. Added "Base data type" to each property (based on format use in ( https://docs.microsoft.com/en-us/sql/t-sql/functions/serverproperty-transact-sql ). Data types discovered using the following query:

SELECT SQL_VARIANT_PROPERTY(COLLATIONPROPERTY(N'Hebrew_100_CS_AS', N'CodePage'), 'basetype'),
       SQL_VARIANT_PROPERTY(COLLATIONPROPERTY(N'Hebrew_100_CS_AS', N'LCID'), 'basetype'),
       SQL_VARIANT_PROPERTY(COLLATIONPROPERTY(N'Hebrew_100_CS_AS', N'ComparisonStyle'), 'basetype'),
       SQL_VARIANT_PROPERTY(COLLATIONPROPERTY(N'Hebrew_100_CS_AS', N'Version'), 'basetype');
-- int    int    int    tinyint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants