Skip to content

update with tuned profile #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktoliver merged 3 commits into from
Feb 21, 2020
Merged

update with tuned profile #4191

ktoliver merged 3 commits into from
Feb 21, 2020

Conversation

@tfevriermsft
Copy link
Contributor

@tfevriermsft tfevriermsft commented Feb 21, 2020

first attempt to propose the tuned profile we have used for our OLTP and DW benchmarks and reviewed with Red Hat.

@tfevriermsft
update with tuned profile
ec1857b 
first attempt to propose the tuned profile we have used for our OLTP and DW benchmarks and reviewed with Red Hat.
@msftclas
Copy link

msftclas commented Feb 21, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@PRMerger7
Copy link
Contributor

PRMerger7 commented Feb 21, 2020

@tfevriermsft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger7 PRMerger7 requested a review from rgward February 21, 2020 03:06
@ktoliver ktoliver added the aq-pr-triaged tracking label for the PR review team label Feb 21, 2020
@PRMerger16 PRMerger16 requested a review from tejasaks February 21, 2020 19:40
@PRMerger16
Copy link
Contributor

PRMerger16 commented Feb 21, 2020

@VanMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@VanMSFT VanMSFT assigned tejasaks and unassigned tejasaks and rgward Feb 21, 2020
@VanMSFT
Copy link
Member

VanMSFT commented Feb 21, 2020

In review

tejasaks
tejasaks approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@tejasaks tejasaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#sign-off

@PRMerger15
Copy link
Contributor

PRMerger15 commented Feb 21, 2020

@tejasaks, you can only sign off in the main PR conversation, not in review comments.

@PRMerger18 PRMerger18 requested a review from tejasaks February 21, 2020 20:49
@PRMerger18
Copy link
Contributor

PRMerger18 commented Feb 21, 2020

@VanMSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@VanMSFT
Copy link
Member

VanMSFT commented Feb 21, 2020

#sign-off

@PRMerger18
Copy link
Contributor

PRMerger18 commented Feb 21, 2020

@VanMSFT: I'm sorry - only the author of this article, @tejasaks, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@tejasaks
Copy link
Contributor

tejasaks commented Feb 21, 2020

#sign-off

@ktoliver
Copy link
Contributor

ktoliver commented Feb 21, 2020

Thanks for reviewing the PR; merging.

@VanMSFT It's preferred to update the metadata author and ms.author attributes in the private repo, for future reference. Thanks!

@ktoliver ktoliver merged commit ba2d78b into MicrosoftDocs:live Feb 21, 2020
@VanMSFT
Copy link
Member

VanMSFT commented Feb 21, 2020

@ktoliver - Thanks, Kristine!

@tfevriermsft
Copy link
Contributor Author

tfevriermsft commented Feb 21, 2020 via email •
edited by VanMSFT
Loading

@ktoliver
Copy link
Contributor

ktoliver commented Feb 21, 2020

Hi @tfevriermsft - I'm not involved in publishing, and I'm not familiar with the publishing process for this public repo (and I don't know where it might be documented).

@rothja Do you know when an update in a merged PR might appear on the live site?

@tfevriermsft
Copy link
Contributor Author

tfevriermsft commented Feb 22, 2020 via email

@tfevriermsft
Copy link
Contributor Author

tfevriermsft commented Feb 22, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VanMSFT VanMSFT VanMSFT left review comments

@rgward rgward Awaiting requested review from rgward

@tejasaks tejasaks Awaiting requested review from tejasaks

Assignees

@tejasaks tejasaks

Labels

aq-pr-triaged tracking label for the PR review team Change sent to author linux/tech ready-to-merge sql/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.