Skip to content

Fix datatype in "Serialization Encoding" section of "Serialization of XML Data" #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jak-MS merged 1 commit into from
Nov 15, 2019
Merged

Fix datatype in "Serialization Encoding" section of "Serialization of XML Data" #3605

Jak-MS merged 1 commit into from
Nov 15, 2019

Conversation

@srutzky
Copy link
Contributor

@srutzky srutzky commented Nov 15, 2019

Datatype was NCHAR when it clearly should have been CHAR as the subsection is dealing with code pages and also even mentioned VARCHAR.

SELECT CONVERT(XML, N'<a>&#x1234;</a>');
-- <a>ሴ</a>


SELECT CONVERT(NCHAR(50), CONVERT(XML, N'<a>&#x1234;</a>'));
-- <a>ሴ</a>                                          


SELECT CONVERT(CHAR(50), CONVERT(XML, N'<a>&#x1234;</a>'));
/*
Msg 6355, Level 16, State 1, Line XXXXX
Conversion of one or more characters from XML to target collation impossible
*/

@srutzky
Fix datatype in "Serialization Encoding" section of "Serialization of…
ab24f2f 
… XML Data"

Datatype was "NCHAR" when it clearly should have been "CHAR" as the subsection is dealing with code pages and also even mentioned "VARCHAR".

(see associated PR for test queries)
@PRMerger9
Copy link
Contributor

PRMerger9 commented Nov 15, 2019

@srutzky : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger9 PRMerger9 requested a review from MightyPen November 15, 2019 19:13
MightyPen
MightyPen approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@MightyPen MightyPen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srutzky Thanks again Solomon! I Approve this PR #3605 .

This PR can now be Merged.

@Jak-MS Jak-MS added the aq-pr-triaged tracking label for the PR review team label Nov 15, 2019
@Jak-MS Jak-MS merged commit c2af44e into MicrosoftDocs:live Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MightyPen MightyPen MightyPen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MightyPen MightyPen

Labels

aq-pr-triaged tracking label for the PR review team Change sent to author do-not-merge sql/prod xml/tech

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srutzky @PRMerger9 @MightyPen @Jak-MS