BREAKING: Handle toJSON in JSON validation and sizing#52
Merged
Conversation
c938fdd to
0bb4400
Compare
hmalik88
reviewed
Dec 6, 2022
hmalik88
reviewed
Dec 6, 2022
hmalik88
reviewed
Dec 6, 2022
hmalik88
reviewed
Dec 6, 2022
hmalik88
reviewed
Dec 6, 2022
0bb4400 to
3048d68
Compare
toJSON in JSON validation and sizingtoJSON in JSON validation and sizing
FrederikBolding
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the JSON validation function in such a way that:
toJSONfunction, it is always called before validating the object.toJSONis being sized.toJSONasresultproperty.This ensures that we size the same object that would be created by
JSON.stringify.Breaking changes
validateJsonAndGetSizenow returns an object, rather than a tuple.