Skip to content

Prevent duplicate click listeners, prepare for gh-pages#4

Merged
rekmarks merged 14 commits intomasterfrom
update-test-dapp
Jan 17, 2020
Merged

Prevent duplicate click listeners, prepare for gh-pages#4
rekmarks merged 14 commits intomasterfrom
update-test-dapp

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Jan 10, 2020 •
edited
Loading

  • Copy latest test dapp from metamask-extension#develop
  • Add @metamask/onboarding dependency
  • Prevent duplicate click listeners: s/addEventListener('click', /onclick(
  • Prepare for gh-pages deployment
    • add deploy script that pushes relevant files to gh-pages branch
    • use unpkg.com/metamask-onboarding as source for onboarding dependency in gh-pages

@whymarrh
Copy link
Copy Markdown
Contributor

whymarrh commented Jan 16, 2020

How does this work? The onlick can b a function but is it assigned anywhere?

@rekmarks
Copy link
Copy Markdown
Member Author

rekmarks commented Jan 16, 2020 •
edited
Loading

How does this work? The onlick can b a function but is it assigned anywhere?

@whymarrh I'm not sure what you mean. We're just replacing addEventListener('click', callback) with onclick(callback). The former adds a new event listener for the given event on the target object; the latter sets a click listener, replacing the existing one, if any.

This is to address a bug in e2e tests caused by duplicate listeners.

Note that these changes are very outdated, and are about to be replaced.

Edit: I am a dumb-dumb. Fixed.

@rekmarks rekmarks force-pushed the update-test-dapp branch 3 times, most recently from 63abbf1 to d1f39ae Compare January 16, 2020 20:17
@rekmarks rekmarks changed the title Prevent duplicate click listeners Prevent duplicate click listeners, prepare for gh-pages Jan 16, 2020
@rekmarks rekmarks requested review from Gudahtt and whymarrh January 16, 2020 20:22
Gudahtt
Gudahtt reviewed Jan 16, 2020
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 16, 2020
View reviewed changes
@rekmarks rekmarks requested a review from Gudahtt January 16, 2020 20:42
@rekmarks rekmarks mentioned this pull request Jan 16, 2020
Closed
Gudahtt
Gudahtt reviewed Jan 16, 2020
View reviewed changes
rekmarks and others added 2 commits January 16, 2020 13:39
@rekmarks @Gudahtt
Update deploy.sh
f4497e2 
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
@rekmarks @Gudahtt
Update deploy.sh
40bf5be 
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
@rekmarks rekmarks requested a review from Gudahtt January 16, 2020 22:54
Gudahtt
Gudahtt reviewed Jan 17, 2020
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 17, 2020
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 17, 2020
View reviewed changes
rekmarks and others added 2 commits January 16, 2020 17:50
@rekmarks @Gudahtt
Update deploy.sh
0edf5b7 
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
@rekmarks
git deploy fixes
a1d00a4
@rekmarks rekmarks requested a review from Gudahtt January 17, 2020 01:56
Gudahtt
Gudahtt approved these changes Jan 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Jan 17, 2020

I just updated the metamask-extension version of this test dapp slightly (MetaMask/metamask-extension@3a2c81d) but I can update that here in a subsequent PR

@rekmarks rekmarks merged commit 09c8d64 into master Jan 17, 2020
@whymarrh whymarrh deleted the update-test-dapp branch January 17, 2020 22:57
jennypollack pushed a commit that referenced this pull request Apr 1, 2020
@BboyAkers
Merge pull request #4 from BboyAkers/aakers-dev
e4b7bce 
refactored contract, send eth, and send tokens section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rekmarks @whymarrh @Gudahtt