Adds a Multisig Contract#207
Merged
PeterYinusa merged 2 commits intoMetaMask:mainfrom Feb 2, 2023
seaona:multisig-contract
Merged
Adds a Multisig Contract#207PeterYinusa merged 2 commits intoMetaMask:mainfrom seaona:multisig-contract
PeterYinusa merged 2 commits intoMetaMask:mainfrom
seaona:multisig-contract
Conversation
8 tasks
pedronfigueiredo
approved these changes
Feb 2, 2023
PeterYinusa
approved these changes
Feb 2, 2023
Contributor
PeterYinusa
left a comment
There was a problem hiding this comment.
LGTM!
Can we also add a button to the test dapp to deploy the contract? Can be in a separate PR
Member
Author
|
Thank you! I will create another PR for adding the button on the UI @PeterYinusa |
This was referenced Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: there's been an issue with Sending ETH to Multisig Wallets, resulting in failing the transaction with the error
Cannot convert string to buffer. See more here: MetaMask/metamask-extension#17488Explanation:
This PR introduces a new Smart Contract for a Multisig Wallet, facilitating the work for testing this functionality on MM e2e.
The Multisig contract is the one created by Solidity By Example and can be found here.
https://solidity-by-example.org/app/multi-sig-wallet/
The subsequent work is finished on MetaMask Extension repo, with this PR:
MetaMask/metamask-extension#17565