Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [841c505]
Page Load Metrics (1314 ± 162 ms)
|
089339b to
88cf475
Compare
Collaborator
Builds ready [88cf475]
Page Load Metrics (1326 ± 123 ms)
|
PeterYinusa
approved these changes
Feb 10, 2023
Member
Author
|
sure @PeterYinusa that's a great idea, since the behaviors differ on the background. I'll create a separate PR for that. And we have another pending one for sending an ERC20 token to a Multisig which will come shortly. |
pedronfigueiredo
approved these changes
Feb 10, 2023
jpuri
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Context: there's been an issue with Sending ETH to Multisig Wallets, resulting in failing the transaction with the error Cannot convert string to buffer. See more here: #17488
What: This PR adds en e2e test for Sending ETH to a Multisig Wallet.
How:
Note: at the moment the test will fail, as the issue is still pending to be fixed. In the video below you can see how the issue is surfacing, proving that the Multisig contract is working correctly.
Once fixed, the test should pass.
Screenshots/Screencaps
send-multisig-e2e.mp4
Before
/
After
/
Manual Testing Steps
yarn build:testyarn test:e2e:single test/e2e/tests/send-hex-address.spec.js --browser=firefox --leave-running=truePre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.