Add Sign-in with Ethereum Test Cases#164
Merged
adonesky1 merged 12 commits intoMetaMask:mainfrom Dec 7, 2022
spruceid:main
Merged
Add Sign-in with Ethereum Test Cases#164adonesky1 merged 12 commits intoMetaMask:mainfrom spruceid:main
adonesky1 merged 12 commits intoMetaMask:mainfrom
spruceid:main
Conversation
Added Sign in with Ethereum Functionality
Added all optional fields
Added test case where account in signature doesn't match account signing
Contributor
|
For the malicious/malformed cases should we be doing some validation in app? |
|
@adonesky1 I think he has some of that going here: MetaMask/metamask-extension#16616 |
BelfordZ
approved these changes
Dec 7, 2022
BelfordZ
left a comment
There was a problem hiding this comment.
looks good.
If/when extension adds better support for SIWE spec, the error cases will change for the better.
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(EIP-4361) Sign-in with Ethereum or SIWE is a standard message format that wallets can parse. In order to facilitate easy testing of some various test cases of this format, 4 cases are presented for signing with a wallet: