Update the test dapp to support onboarding#1
Closed
Gudahtt wants to merge 6 commits intoMetaMask:masterfrom
Closed
Update the test dapp to support onboarding#1Gudahtt wants to merge 6 commits intoMetaMask:masterfrom
Gudahtt wants to merge 6 commits intoMetaMask:masterfrom
Conversation
It now uses the `@metamask/onboarding` library to help with onboarding. Large parts of the dapp have been re-written as well. The markup has been updated to use semantic tags where appropriate, and to remove unnecessary elements. The JavaScript has been updated to wait for the `Connect` button to be pressed before connecting, and to set buttons as disabled when they cannot be used.
Gudahtt
commented
Nov 21, 2019
Member
Author
|
Closing this, as it's outdated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now uses the
@metamask/onboardinglibrary to help with onboarding.Large parts of the dapp have been re-written as well. The markup has been updated to use semantic tags where appropriate, and to remove unnecessary elements. The JavaScript has been updated to wait for the
Connectbutton to be pressed before connecting, and to set buttons as disabled when they cannot be used.