BREAKING: Remove :snapAdded event#2073
Merged
FrederikBolding merged 1 commit intomainfrom Jan 8, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
- Coverage 96.28% 96.28% -0.01%
==========================================
Files 270 270
Lines 6303 6301 -2
Branches 1018 1018
==========================================
- Hits 6069 6067 -2
Misses 234 234 ☔ View full report in Codecov by Sentry. |
hmalik88
approved these changes
Jan 5, 2024
FrederikBolding
added a commit
that referenced
this pull request
Jan 8, 2024
After merging #2073, I realized that we might as well remove `:snapRemoved` too. It is more confusing than `:snapUninstalled` and all current use-cases can be covered with the previously mentioned event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #2069 we can now remove the
snapAddedevent as it doesn't have a use-case anymore.