Bump semver to ensure signed provenance, CVE fix#1631
Merged
FrederikBolding merged 2 commits intoMetaMask:mainfrom Jul 21, 2023
x86NOP:bump-semver
Merged
Bump semver to ensure signed provenance, CVE fix#1631FrederikBolding merged 2 commits intoMetaMask:mainfrom x86NOP:bump-semver
FrederikBolding merged 2 commits intoMetaMask:mainfrom
x86NOP:bump-semver
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1631 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 235 235
Lines 5342 5342
Branches 819 819
=======================================
Hits 5117 5117
Misses 225 225
|
FrederikBolding
approved these changes
Jul 21, 2023
Mrtenz
approved these changes
Jul 21, 2023
FrederikBolding
pushed a commit
that referenced
this pull request
Aug 7, 2023
Co-authored-by: Craig Scheets <craig.scheets@consensys.io>
FrederikBolding
pushed a commit
that referenced
this pull request
Aug 8, 2023
Co-authored-by: Craig Scheets <craig.scheets@consensys.io>
Gudahtt
pushed a commit
that referenced
this pull request
Aug 14, 2023
Co-authored-by: Craig Scheets <craig.scheets@consensys.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Many snaps recently audited used vulnerable package during audits/reviews.
Solutions: Bumping semver to ^7.5.4 (latest) in MetaMask/snaps and MetaMask/utils to ensure snap authors (and all other future imports) use version built/signed with provenance (new in >= 7.5.1) and fix CVE-2022-25883 (>= 7.5.2).
I spoke with @FrederikBolding yesterday, related PRs:
semveras requested by Dependabot #1603 (approved 2023-07-14)