fix: automatically refresh transaction expiration#299
Merged
Conversation
40323a4 to
c8b9525
Compare
3d07287 to
ad2d7a2
Compare
b76b4a6 to
d009136
Compare
ulissesferreira
commented
May 14, 2026
| } | ||
| } | ||
|
|
||
| async #ensureFreshRawData<RawDataType extends TransactionRawData>( |
Contributor
Author
There was a problem hiding this comment.
You might wonder why we have a private method with the same name as above. The reason is that we are sharing this method between the public 3 ones above. We need to have tronWeb as a param for it so we don't keep re-instantiating it. In a future PR this will not be a problem because Tronweb will have one instance per network readily available for the whole Snap instead of the existing factory pattern.
The factory pattern was useful when we were storing the instances but for some reason this stopped being the case it seems.
3286a53 to
44ac903
Compare
ulissesferreira
commented
May 14, 2026
ulissesferreira
commented
May 14, 2026
67d799e to
0b76de1
Compare
4d380e6 to
d4386a4
Compare
d4386a4 to
9a16d70
Compare
3b57287 to
9a16d70
Compare
## Summary - Moves transaction metadata refresh test coverage onto a stacked branch above #299 - Re-enables the tests that are skipped on the base PR branch - Restores the higher coverage thresholds supported by the added tests ## Verification - yarn lint:fix - yarn test
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
|
@metamaskbot publish-preview |
1 similar comment
Contributor
|
@metamaskbot publish-preview |
maxime-oe
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expiration,ref_block_bytes, andref_block_hashbefore signing in both send/broadcast paths.