feat: add i18n support for malicious website labels#276
Merged
jeffsmale90 merged 1 commit intofeat/dapp-scanningfrom Mar 4, 2026
Merged
feat: add i18n support for malicious website labels#276jeffsmale90 merged 1 commit intofeat/dapp-scanningfrom
jeffsmale90 merged 1 commit intofeat/dapp-scanningfrom
Conversation
Add translation keys for malicious and potentially malicious website labels: - maliciousWebsiteLabel: 'Malicious website' (English) - potentiallyMaliciousWebsiteLabel: 'Potentially malicious website' (English) Updated all locale files with these keys. Non-English translations are left empty for future translation work. Refs #275 Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com>
jeffsmale90
added a commit
that referenced
this pull request
Mar 5, 2026
* Add dappscanning to wallet_requestExecutionPermissions requests - trigger request to dapp scanning api when processing a permission request - show the result if it is WARN or BLOCK * Refactor trustSignal in permissionHandlerContent.tsx Fix tests * feat: add i18n support for malicious website labels (#276) Add translation keys for malicious and potentially malicious website labels: - maliciousWebsiteLabel: 'Malicious website' (English) - potentiallyMaliciousWebsiteLabel: 'Potentially malicious website' (English) Updated all locale files with these keys. Non-English translations are left empty for future translation work. Refs #275 Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com> * TrustSignalsClient only resolves a recommended action if 'isComplete'. Defaults to 'NONE' if no legitimate result is found. * Calls to updateConfirmation should queue and wait for previous calls to finish to avoid overwriting data * Rename 'trust signals api' to 'dapp scanning api' * Add security scanning api * Also show alerts for scanned "from" address * Refactor and simplify - fields with warnings - permissionRequestLifecycleOrchestrator's updateConfirmation function - fix tests * Ensure that address scanning results with label as empty string coalesce to the standard label * Pass new environment variables to GH actions --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add translation keys for malicious and potentially malicious website labels:
Updated all locale files with these keys. Non-English translations are left empty for future translation work.
Refs #275
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: UI-only string changes with English fallback preserved; main risk is missing/empty locale entries causing fallback-to-English behavior in non-English locales.
Overview
Adds i18n support for trust-signal labels shown next to the request origin. The permission confirmation UI now renders the “malicious website” and “potentially malicious website” labels via
t('maliciousWebsiteLabel')/t('potentiallyMaliciousWebsiteLabel')instead of hardcoded English.All locale JSONs are updated to include these two new message keys (English populated; other locales left empty to fall back to English).
Written by Cursor Bugbot for commit 6016323. This will update automatically on new commits. Configure here.