Merged
Conversation
53ae069 to
9e2787c
Compare
legobeat
reviewed
Feb 22, 2024
| ## [7.0.0] | ||
| ### Added | ||
| - Integrate `PollingController` mixin into `SmartTransactionsController` and implement the abstract `_executePoll` method ([#237](https://github.com/MetaMask/smart-transactions-controller/pull/237)) | ||
| - Validation can be now be circumvented by passing the `skipConfirm` option ([#271](https://github.com/MetaMask/smart-transactions-controller/pull/271)) |
Contributor
mcmire
reviewed
Feb 23, 2024
Contributor
mcmire
left a comment
There was a problem hiding this comment.
This is a big release! 😅 I tried my best to go through every change in every PR. I think I got it all. I realize some of the suggestions may conflict with one another, so let me know if it'd be easier for me to make them myself.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ |
Contributor
|
@legobeat I've applied all of the suggestions I made above and also added entries for 279 and 282. I'm okay with merging this if we don't get a response. |
mcmire
previously approved these changes
Mar 13, 2024
legobeat
approved these changes
Mar 14, 2024
Closed
legobeat
previously requested changes
Mar 19, 2024
Contributor
|
This has been merged after last update of changelog in this PR: |
pedronfigueiredo
approved these changes
Mar 19, 2024
I am okay to add two more PRs to this release. It seems like we will hold off until merging more PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 7.0.0.