Skip to content

Emit an event after a tx is confirmed, remove "skipConfirm", return "txHash"#298

Merged
dan437 merged 9 commits intomainfrom
stx-updates-1
Mar 19, 2024
Merged

Emit an event after a tx is confirmed, remove "skipConfirm", return "txHash"#298
dan437 merged 9 commits intomainfrom
stx-updates-1

Conversation

@dan437
Copy link
Copy Markdown
Collaborator

@dan437 dan437 commented Mar 18, 2024

Description

This PR includes multiple things:

  • Emit an event after a tx is confirmed
  • Remove "skipConfirm"
  • Return "txHash"
  • Change to: public eventEmitter: EventEmitter;

@dan437 dan437 requested a review from a team March 18, 2024 14:24
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ethereumjs/common@4.2.0 Transitive: network +8 4.09 MB holgerd77
npm/@ethereumjs/rlp@5.0.2 None 0 134 kB holgerd77
npm/@ethereumjs/tx@5.2.1 Transitive: network +9 4.75 MB holgerd77
npm/@ethereumjs/util@9.0.2 network +7 3.43 MB holgerd77
npm/@types/bn.js@5.1.1 None +1 1.8 MB types
npm/@types/pbkdf2@3.1.0 None +1 1.79 MB types
npm/@types/secp256k1@4.0.3 None +1 1.79 MB types
npm/base-x@3.0.8 None +1 41.6 kB junderw
npm/blakejs@1.1.1 None 0 160 kB dcposch
npm/brorand@1.1.0 None 0 3.52 kB indutny
npm/browserify-aes@1.2.0 Transitive: environment +13 287 kB cwmma
npm/bs58@4.0.1 None +2 46.2 kB dcousens
npm/bs58check@2.1.2 Transitive: environment +13 267 kB dcousens
npm/buffer-xor@1.0.3 None 0 4.83 kB dcousens
npm/cipher-base@1.0.4 None +2 44 kB cwmma
npm/create-hash@1.2.0 Transitive: environment +10 248 kB cwmma
npm/create-hmac@1.1.7 Transitive: environment +11 254 kB cwmma
npm/elliptic@6.5.4 None +7 295 kB indutny
npm/ethereumjs-util@7.1.4 Transitive: environment, filesystem +41 7.63 MB holgerd77
npm/evp_bytestokey@1.0.3 Transitive: environment +7 199 kB dcousens
npm/hash-base@3.1.0 Transitive: environment +5 186 kB fanatid
npm/hash.js@1.1.7 None +2 47.2 kB indutny
npm/hmac-drbg@1.0.1 None +4 76.9 kB indutny
npm/ip@2.0.0 None 0 13.6 kB indutny
npm/keccak@3.0.4 Transitive: environment, filesystem +7 1.77 MB fanatid
npm/md5.js@1.3.5 Transitive: environment +6 194 kB cwmma
npm/minimalistic-assert@1.0.1 None 0 1.55 kB cwmma
npm/minimalistic-crypto-utils@1.0.1 None 0 4.76 kB indutny
npm/node-addon-api@2.0.2 None 0 799 kB nicknaso
npm/node-gyp-build@4.8.0 environment, filesystem 0 13.4 kB mafintosh
npm/pbkdf2@3.1.2 Transitive: environment +12 267 kB cwmma
npm/randombytes@2.1.0 None +1 38.5 kB cwmma
npm/ripemd160@2.0.2 Transitive: environment +6 196 kB dcousens
npm/rlp@2.2.7 None +1 162 kB ralxz
npm/scrypt-js@3.0.1 None 0 226 kB ricmoo
npm/secp256k1@4.0.3 Transitive: environment, filesystem +10 3 MB fanatid
npm/setimmediate@1.0.5 None 0 8.56 kB domenic
npm/sha.js@2.4.11 None +2 67.1 kB dcousens

🚮 Removed packages: npm/ip@2.0.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 18, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Mild CVE npm/ip@2.0.0
New author npm/md5.js@1.3.5
New author npm/ripemd160@2.0.2
New author npm/bs58@4.0.1
New author npm/rlp@2.2.7
Native code npm/secp256k1@4.0.3
Native code npm/keccak@3.0.4
Network access npm/@ethereumjs/util@9.0.2

View full report↗︎

Next steps

What is a mild CVE?

Contains a low severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/ip@2.0.0
  • @SocketSecurity ignore npm/md5.js@1.3.5
  • @SocketSecurity ignore npm/ripemd160@2.0.2
  • @SocketSecurity ignore npm/bs58@4.0.1
  • @SocketSecurity ignore npm/rlp@2.2.7
  • @SocketSecurity ignore npm/secp256k1@4.0.3
  • @SocketSecurity ignore npm/keccak@3.0.4
  • @SocketSecurity ignore npm/@ethereumjs/util@9.0.2

@dan437 dan437 requested a review from infiniteflower March 18, 2024 14:35
@dan437 dan437 merged commit aed85b9 into main Mar 19, 2024
@dan437 dan437 deleted the stx-updates-1 branch March 19, 2024 10:08
@legobeat legobeat mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants