Skip to content

Use @metamask/eslint-config@3.1.0#27

Merged
whymarrh merged 1 commit intoMetaMask:masterfrom
whymarrh:update-metamask-eslint-config
Aug 19, 2020
Merged

Use @metamask/eslint-config@3.1.0#27
whymarrh merged 1 commit intoMetaMask:masterfrom
whymarrh:update-metamask-eslint-config

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

This PR updates the @metamask/eslint-config dependency to the latest published version, v3.1.0.

@whymarrh whymarrh requested a review from a team as a code owner August 19, 2020 16:26
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing this line as well: https://github.com/MetaMask/eth-rpc-errors/blob/master/.eslintrc.js#L17

It's no longer required on v3.1.0 of the shared config.

@whymarrh whymarrh force-pushed the update-metamask-eslint-config branch from a0a43b9 to 739250b Compare August 19, 2020 16:37
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 188de6c into MetaMask:master Aug 19, 2020
@whymarrh whymarrh deleted the update-metamask-eslint-config branch August 19, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants