Conversation
brad-decker
previously approved these changes
May 11, 2020
56decd9 to
4e5282e
Compare
Gudahtt
reviewed
May 11, 2020
Gudahtt
reviewed
May 11, 2020
.eslintrc.js
Outdated
| @@ -0,0 +1,29 @@ | |||
| module.exports = { | |||
| env: { | |||
Member
There was a problem hiding this comment.
It would be better to omit this if possible. All the env property does is enable the corresponding global variables, and we don't want to allow any browser globals to be used ideally (since this module can also be used in a Node.js environment).
We can omit es6 as well, since it's implied by the setting our ecmaVersion to 2018. So I suppose commonjs is all we need to include (so that require is allowed as a global)?
Member
Author
There was a problem hiding this comment.
Looks like we could remove even more stuff than that! cdbc270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/eslint-configand related packages