Fix ObservableStore.updateState and constructor type bugs#38
Merged
Conversation
Gudahtt
added a commit
that referenced
this pull request
Apr 3, 2023
This library has used an empty object as the default initial state ever since the initial version, but in older versions that was only set if the initial state was undefined. An initial state of `null` or any other falsy value other than `undefined` was still accepted. In #38 (published as part of v6.0.2) this was accidentally changed. Instead the empty object default was used for any falsy value passed in as the initial state. The pre-v6.0.2 behavior has now been restored; falsy initial state is no longer overwritten.
Gudahtt
added a commit
that referenced
this pull request
Apr 3, 2023
This library has used an empty object as the default initial state ever since the initial version, but in older versions that was only set if the initial state was undefined. An initial state of `null` or any other falsy value other than `undefined` was still accepted. In #38 (published as part of v6.0.2) this was accidentally changed. Instead the empty object default was used for any falsy value passed in as the initial state. The pre-v6.0.2 behavior has now been restored; falsy initial state is no longer overwritten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Partial<T>whereTis its generic type