Skip to content

Rename package from nonce-tracker to @metamask/nonce-tracker#61

Merged
legobeat merged 2 commits intoMetaMask:mainfrom
legobeat:rename-package-metamask-scope
Dec 5, 2023
Merged

Rename package from nonce-tracker to @metamask/nonce-tracker#61
legobeat merged 2 commits intoMetaMask:mainfrom
legobeat:rename-package-metamask-scope

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Nov 30, 2023 •
edited
Loading

Blocked by

@legobeat legobeat requested a review from a team as a code owner November 30, 2023 02:46
@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 30, 2023 •
edited
Loading

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@legobeat legobeat requested a review from MajorLift November 30, 2023 02:47
@legobeat legobeat force-pushed the rename-package-metamask-scope branch from 60e2397 to 08ef41a Compare November 30, 2023 02:49
mcmire
mcmire previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat force-pushed the rename-package-metamask-scope branch from 08ef41a to 1bacb24 Compare December 5, 2023 03:04
@legobeat legobeat requested a review from mcmire December 5, 2023 03:04
MajorLift
MajorLift requested changes Dec 5, 2023
View reviewed changes
Copy link
Copy Markdown

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the first line of the README as well (example).

@@ -1,1 +1,1 @@
-# nonce-tracker
+# `@metamask/nonce-tracker`

Otherwise looks good!

@legobeat legobeat requested a review from MajorLift December 5, 2023 22:01
@legobeat legobeat merged commit eb5ca24 into MetaMask:main Dec 5, 2023
@legobeat legobeat deleted the rename-package-metamask-scope branch December 5, 2023 22:07
legobeat added a commit to legobeat/nonce-tracker that referenced this pull request May 27, 2024
@legobeat
Rename package from nonce-tracker to @metamask/nonce-tracker (MetaMas…
bb8c219 
…k#61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MajorLift MajorLift MajorLift approved these changes

@mcmire mcmire Awaiting requested review from mcmire

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @mcmire @MajorLift