Skip to content

export ancillary types#53

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:types-export
Nov 14, 2023
Merged

export ancillary types#53
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:types-export

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Oct 23, 2023 •
edited
Loading

  • Explicitly export types
  • BREAKING: Change NonceTracker into named export.
// Old usage
const NonceTracker = require('nonce-tracker');

// New usage
const { NonceTracker } = require('nonce-tracker');

@legobeat legobeat mentioned this pull request Oct 23, 2023
Merged
3 tasks
@legobeat legobeat requested a review from a team November 8, 2023 02:24
@legobeat legobeat marked this pull request as ready for review November 8, 2023 02:24
@legobeat legobeat requested a review from a team as a code owner November 8, 2023 02:24
mcmire
mcmire approved these changes Nov 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@legobeat legobeat merged commit ceb1196 into MetaMask:main Nov 14, 2023
@legobeat legobeat mentioned this pull request Nov 15, 2023
Merged
3 tasks
legobeat added a commit to legobeat/nonce-tracker that referenced this pull request May 27, 2024
@legobeat
Export types; Move NonceTracker to named export instead of default (M…
93efedc 
…etaMask#53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire approved these changes

@OGPoyraz OGPoyraz Awaiting requested review from OGPoyraz

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0

@vinistevam vinistevam Awaiting requested review from vinistevam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @mcmire