Conversation
|
I was investigating whether we could publish using a custom GitHub actions workflow rather than use a branch, and rely upon the environment required reviewers setting instead of PR review. But unfortunately that API doesn't seem well suited for publishing to a subdirectory. The only option is to overwrite the entire site. We could download the current site and merge changes into it, except that I can't see a way to download the current site either. So long as we're publishing to subdirectories, we're stuck with the |
e854174 to
0b0b55f
Compare
The `publish-docs` workflow has been updated to use a personal access token for publishing docs instead of using the `GITHUB_TOKEN`. This allows for more control over doc publishing permissions.
0b0b55f to
62fb0b9
Compare
|
I have just updated this PR to forward secrets to the publishing workflow, which wasn't being done before. I expect that this would have failed beforehand, because the secret would have been missing. I haven't tested this with a fork yet, I'll do that before bringing this back out of draft again. I'll add an example as well, I noticed that step was missed too. Update: I can't test this with a fork because the "bypass review" branch protection setting isn't available on forks. But I'll test it on the utils repo first at least. |
62fb0b9 to
359e92b
Compare
|
Marking this as ready for review because it has now been tested in the utils repo. |
The
publish-docsworkflow has been updated to use a personal access token for publishing docs instead of using theGITHUB_TOKEN. This allows for more control over doc publishing permissions.Fixes #184
Examples
This has been implemented in the
utilslibrary: MetaMask/utils#96