Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
This requires some changes to the repository settings, but I will wait until just prior to merge before making those changes to avoid disrupting other PRs. Typically I would test action changes in a fork, but in this case it's challenging because we're relying upon a feature not available without a paid plan (the ability to let metamaskbot bypass the review requirement), so I can't test it. |
The `publish-docs` workflow has been updated to use a personal access token for publishing docs instead of using the `GITHUB_TOKEN`. This allows for more control over doc publishing permissions. Relates to MetaMask/metamask-module-template#184
2a903aa to
2198d49
Compare
Mrtenz
approved these changes
Apr 11, 2023
Member
Author
|
The required settings changes (as documented here) have been made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish-docsworkflow has been updated to use a personal access token for publishing docs instead of using theGITHUB_TOKEN. This allows for more control over doc publishing permissions.Relates to MetaMask/metamask-module-template#184