Skip to content

chore: cherry-pick #9342#9370

Merged
chrisleewilcox merged 2 commits intorelease/7.21.0from
chore/cherry-pick-9342
Apr 23, 2024
Merged

chore: cherry-pick #9342#9370
chrisleewilcox merged 2 commits intorelease/7.21.0from
chore/cherry-pick-9342

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR cherry-picks #9342

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Update @blockaid/ppom_release package to 1.4.5


## **Related issues**

Fixes: #24172

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@pedronfigueiredo pedronfigueiredo self-assigned this Apr 23, 2024
@pedronfigueiredo pedronfigueiredo added team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead team-confirmations-secure-ux-PR PR from the confirmations team labels Apr 23, 2024
@pedronfigueiredo pedronfigueiredo marked this pull request as ready for review April 23, 2024 11:04
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner April 23, 2024 11:04
@pedronfigueiredo pedronfigueiredo requested a review from a team April 23, 2024 11:04
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/ppom_release@1.4.6 network 0 3.32 MB blockaiduser

🚮 Removed packages: npm/@blockaid/ppom_release@1.4.5

View full report↗︎

@github-actions
Copy link
Copy Markdown
Contributor Author

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona
Copy link
Copy Markdown
Member

seaona commented Apr 23, 2024

🟢 I confirm ppom-module continues to work normally after the upgrade

Screenshot from 2024-04-23 14-05-33

@seaona seaona requested a review from sethkfman April 23, 2024 15:58
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit ade0bf7 into release/7.21.0 Apr 23, 2024
@chrisleewilcox chrisleewilcox deleted the chore/cherry-pick-9342 branch April 23, 2024 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 23, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.21.0 on PR, as PR was cherry-picked in branch 7.21.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants