Skip to content

chore: add migration to remove swaps controller background state#24172

Closed
infiniteflower wants to merge 1 commit intomainfrom
chore/swaps-controller-remove-migration
Closed

chore: add migration to remove swaps controller background state#24172
infiniteflower wants to merge 1 commit intomainfrom
chore/swaps-controller-remove-migration

Conversation

@infiniteflower
Copy link
Copy Markdown
Contributor

@infiniteflower infiniteflower commented Dec 18, 2025

Description

This PR adds a migration to remove SwapsController from the background state.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3493

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Dec 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSwaps, SmokeTrade, SmokeCore
  • Risk Level: medium
  • AI Confidence: 80%
click to see 🤖 AI reasoning details

This PR adds a new state migration (migration 110) that removes the SwapsController state from the persisted backgroundState. The migration comment indicates that SwapsController functionality has been moved to BridgeController/unified swaps.

Key observations:

  1. The migration is straightforward - it simply deletes the SwapsController property from backgroundState if it exists
  2. SwapsController is still actively used in the codebase (in Swaps UI components, Bridge components, AssetOverview, etc.)
  3. The migration only removes persisted state, not the controller itself - the controller will still function but start fresh without cached data
  4. This is a cleanup migration for deprecated persisted state

The changes are well-tested with unit tests covering various scenarios (missing state, successful removal, error handling).

Selected tags rationale:

  • SmokeSwaps: Directly tests swap functionality which uses SwapsController
  • SmokeTrade: Tests token swaps, bridge, and DEX trading - all related to the affected controller
  • SmokeCore: Tests core wallet functionality and app state - migrations affect app state initialization

The risk is medium because while the migration is simple, it affects a core feature (swaps) and any issues with state migration could impact user experience when upgrading the app.

View GitHub Actions results

@infiniteflower infiniteflower added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Dec 18, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 18, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions bot closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-M stale Issues that have not had activity in the last 90 days team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@infiniteflower @metamaskbot