chore: cherry-pick #9243#9265
Merged
chrisleewilcox merged 1 commit intorelease/7.21.0from Apr 16, 2024
Merged
Conversation
…9243) ## **Description** Fixes #9242 and #9244 More specifically, fixes these 2 issues: - URL not called properly for Stake button since constant name changes (broken Portfolio Stake link) - `isPortfolioUrl` is not imported in app/components/UI/Tokens/index.tsx (broken Portfolio home link) **NOTE**: These [breaking issues](#8674) should have been caught by the typechecker which is [currently disabled for the components folder](https://github.com/MetaMask/metamask-mobile/blob/ef475b788f9be7f0d2b66ea749045772ed899ba0/tsconfig.lint.json#L11). I'd strongly advise that this is re-implemented as these issues could have been easily been caught at the commit or CI level. ## **Related issues** Fixes: #9242 and #9244 ## **Manual testing steps** - Go to Token Listing - Verify that the new staking icon shows up on ETH on mainnet - Verify that onPress, the MM browser opens up the Portfolio stake page with the correct query params (https://portfolio.metamask.io/stake?metamaskEntry=mobile) - Verify that if a browser tab is already open on the stake page, the MM browser picks this tab rather than opening a new one - Verify that the Token Listing Portfolio button opens up the portfolio page (https://portfolio.metamask.io?metamaskEntry=mobile) and does not crash the app ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-mobile/assets/22345430/05d258d8-e962-4297-9e2d-b6f7a47f688f ### **After** https://github.com/MetaMask/metamask-mobile/assets/22345430/8b7cdca4-1028-45e3-8da8-074d80e70755 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
NicolasMassart
approved these changes
Apr 16, 2024
Contributor
NicolasMassart
left a comment
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #9243