Skip to content

chore: cherry-pick #9243#9265

Merged
chrisleewilcox merged 1 commit intorelease/7.21.0from
chore/cherry-pick-9243
Apr 16, 2024
Merged

chore: cherry-pick #9243#9265
chrisleewilcox merged 1 commit intorelease/7.21.0from
chore/cherry-pick-9243

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR cherry-picks #9243

…9243)

## **Description**

Fixes #9242 and
#9244

More specifically, fixes these 2 issues:

- URL not called properly for Stake button since constant name changes
(broken Portfolio Stake link)
- `isPortfolioUrl` is not imported in app/components/UI/Tokens/index.tsx
(broken Portfolio home link)

**NOTE**: These [breaking
issues](#8674) should
have been caught by the typechecker which is [currently disabled for the
components
folder](https://github.com/MetaMask/metamask-mobile/blob/ef475b788f9be7f0d2b66ea749045772ed899ba0/tsconfig.lint.json#L11).
I'd strongly advise that this is re-implemented as these issues could
have been easily been caught at the commit or CI level.

## **Related issues**

Fixes: #9242 and
#9244

## **Manual testing steps**

- Go to Token Listing
- Verify that the new staking icon shows up on ETH on mainnet
- Verify that onPress, the MM browser opens up the Portfolio stake page
with the correct query params
(https://portfolio.metamask.io/stake?metamaskEntry=mobile)
- Verify that if a browser tab is already open on the stake page, the MM
browser picks this tab rather than opening a new one
- Verify that the Token Listing Portfolio button opens up the portfolio
page (https://portfolio.metamask.io?metamaskEntry=mobile) and does not
crash the app

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/MetaMask/metamask-mobile/assets/22345430/05d258d8-e962-4297-9e2d-b6f7a47f688f

### **After**


https://github.com/MetaMask/metamask-mobile/assets/22345430/8b7cdca4-1028-45e3-8da8-074d80e70755

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@ameliejyc ameliejyc marked this pull request as ready for review April 16, 2024 16:08
@ameliejyc ameliejyc requested a review from a team as a code owner April 16, 2024 16:08
Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chrisleewilcox chrisleewilcox added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-stake-deprecated DEPRECATED: please use "team-earn" instead labels Apr 16, 2024
@chrisleewilcox chrisleewilcox merged commit b191be0 into release/7.21.0 Apr 16, 2024
@chrisleewilcox chrisleewilcox deleted the chore/cherry-pick-9243 branch April 16, 2024 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-stake-deprecated DEPRECATED: please use "team-earn" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants