Skip to content

feat: Cherry pick controller utils v5#9222

Merged
tommasini merged 2 commits intorelease/7.21.0from
feat/cherry-pick-controller-utils-v5
Apr 12, 2024
Merged

feat: Cherry pick controller utils v5#9222
tommasini merged 2 commits intorelease/7.21.0from
feat/cherry-pick-controller-utils-v5

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

Description

This PR cherry-picks this PR that updates controller utils to v5

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

Updated the patch accordingly, and introduced networkIds list hardcoded
for we keep the ens legacy functions working

* The patch controller-utils would be able to be removed on v8 and v9 of
controller-utils
* Added a temporary resolution for the dependency of transaction
controller controller utils be bumped to version 5 to keep linea sepolia
transactions working. It will be removed when transaction controller be
updated to v13
* This PR needs assets controller
[PR](#9182) v14 be
merged to have auto nfts detection working

## **Related issues**

Fixes: MetaMask/mobile-planning#1622

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

ENS solving: 


https://github.com/MetaMask/metamask-mobile/assets/46944231/bb8eecd4-951d-427f-9356-9b4ba0e65a0d


Sepolia linea network:

Uploading Screen Recording 2024-04-11 at 11.16.38.mov…


NFT auto detection working


https://github.com/MetaMask/metamask-mobile/assets/46944231/ce4efcf8-5678-4b7b-965a-30499db67e17




### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Apr 12, 2024
@tommasini tommasini requested a review from a team April 12, 2024 14:37
@tommasini tommasini requested a review from a team as a code owner April 12, 2024 14:37
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c4b9093
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58a95226-c109-4643-bf7f-fdba27280aad

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 62fbb98
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7ee01801-8ebe-4246-85e2-d4ff0c34985a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tommasini tommasini merged commit 80c6a3a into release/7.21.0 Apr 12, 2024
@tommasini tommasini deleted the feat/cherry-pick-controller-utils-v5 branch April 12, 2024 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 12, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.21.0 on PR, as PR was cherry-picked in branch 7.21.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants