Skip to content

feat: cherry-pick assets controller v14 #9218

Merged
tommasini merged 1 commit intorelease/7.21.0from
feat/cherry-pick-assets-controllers-v14
Apr 12, 2024
Merged

feat: cherry-pick assets controller v14 #9218
tommasini merged 1 commit intorelease/7.21.0from
feat/cherry-pick-assets-controllers-v14

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

Description

This PR cherry picks assets controllers v^14 that was merged on this PR

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**
This PR addresses the update to the Asset Controller v14

Created Core branch to address patch changes:
patch/mobile-assets-controllers-v-14-0-0

Fixed issue of token being automatically imported when requested by a
dapp.

Changed breaking changes on addToken and watchAsset function signature.

Important to note that this version of assets controller is pointing to
version 5 of controller utils, therefore the auto detect tokens will
only be available when this
[PR](#9149) is merged

## **Related issues**

Fixes: MetaMask/mobile-planning#1620

## **Manual testing steps**

1. imported tokens on mainnet
2. Imported tokens on custom network
3. Auto-detect tokens on mainnet & custom network
4. Import token via dapp
5.

## **Screenshots/Recordings**

Auto detect tokens, import token via dapp:


https://github.com/MetaMask/metamask-mobile/assets/46944231/daed21fe-1bbe-432e-9c1d-71e7ccc3baa9


Add custom token/ hide token:



https://github.com/MetaMask/metamask-mobile/assets/46944231/a1911455-136f-436b-924f-01f8d5bcd5a9




### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@tommasini tommasini requested a review from a team as a code owner April 12, 2024 13:35
@tommasini tommasini requested a review from a team April 12, 2024 13:35
@tommasini tommasini requested review from a team as code owners April 12, 2024 13:35
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@14.0.0 Transitive: filesystem, network +24 3.3 MB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@12.0.0

View full report↗︎

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6270d3e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6caed527-8510-4cb3-8e95-df2c7178afc8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Apr 12, 2024
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit e8dd127 into release/7.21.0 Apr 12, 2024
@tommasini tommasini deleted the feat/cherry-pick-assets-controllers-v14 branch April 12, 2024 15:11
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.21.0 on PR, as PR was cherry-picked in branch 7.21.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants