Skip to content

fix: update PPOM to v1.4.4 (#8863)#8869

Merged
sethkfman merged 1 commit into
release/7.18.0from
cherry-pick-ppom-fix
Mar 7, 2024
Merged

fix: update PPOM to v1.4.4 (#8863)#8869
sethkfman merged 1 commit into
release/7.18.0from
cherry-pick-ppom-fix

Conversation

@seaona

@seaona seaona commented Mar 6, 2024

Copy link
Copy Markdown
Member

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Mar 6, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.60%. Comparing base (a0e4022) to head (8eca7b0).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release/7.18.0    #8869   +/-   ##
===============================================
  Coverage           41.60%   41.60%           
===============================================
  Files                1269     1269           
  Lines               30859    30859           
  Branches             3082     3082           
===============================================
  Hits                12840    12840           
  Misses              17243    17243           
  Partials              776      776

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sethkfman sethkfman changed the base branch from release/7.18.0 to release/7.17.1 March 6, 2024 19:53
@sethkfman sethkfman changed the base branch from release/7.17.1 to release/7.18.0 March 6, 2024 19:53
@seaona

seaona commented Mar 6, 2024

Copy link
Copy Markdown
Member Author

This has been tested and has QA pass. Here vid evidence

@seaona seaona added the QA Passed QA testing has been completed and passed label Mar 6, 2024
@seaona seaona marked this pull request as ready for review March 6, 2024 20:49
@seaona seaona requested a review from a team as a code owner March 6, 2024 20:49
@github-actions

github-actions Bot commented Mar 6, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8eca7b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e622ed78-9cfd-452d-9058-e3f46b344666

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman approved these changes Mar 7, 2024
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit 0e42b90 into release/7.18.0 Mar 7, 2024
@sethkfman sethkfman deleted the cherry-pick-ppom-fix branch March 7, 2024 19:34
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 7, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 19, 2024
@metamaskbot

metamaskbot commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.18.0 on PR, as PR was added to branch 7.18.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.18.0 Issue or pull request that will be included in release 7.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seaona @codecov-commenter @metamaskbot @sethkfman @jpuri