Skip to content

chore: update ses.cjs#8786

Closed
eltociear wants to merge 1 commit into
MetaMask:mainfrom
eltociear:patch-4
Closed

chore: update ses.cjs#8786
eltociear wants to merge 1 commit into
MetaMask:mainfrom
eltociear:patch-4

Conversation

@eltociear

Copy link
Copy Markdown
Contributor

Description

minor fix

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@eltociear eltociear requested a review from a team as a code owner February 29, 2024 15:16
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 29, 2024
@leotm

leotm commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

thx for spotting @eltociear ^ could you open create the PR upstream here instead: https://github.com/endojs/endo

(targeting https://github.com/endojs/endo/blob/master/packages/ses/src/make-eval-function.js)

then we can go ahead close this PR, then update SES for the update

leotm added a commit that referenced this pull request May 15, 2024
@leotm leotm mentioned this pull request May 15, 2024
7 tasks
leotm added a commit that referenced this pull request May 29, 2024
## **Description**

- bump SES to
[v1.5.0](https://github.com/endojs/endo/releases/tag/ses%401.5.0)
- includes Hermes fix in preparation for Hermes SES shim

## **Related issues**

- includes endojs/endo#2206
- includes #8786

## **Manual testing steps**

Run: `curl -O https://npmfs.com/download/ses/1.5.0/dist/ses.cjs`
Result: no change/diff

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale Issues that have not had activity in the last 90 days label Jun 12, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions Bot closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template stale Issues that have not had activity in the last 90 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants