Skip to content

feat: Snaps new architecture mobile integration#8700

Merged
Jonathansoufer merged 40 commits into
mainfrom
feat/snaps-integration-refactor
Feb 27, 2024
Merged

feat: Snaps new architecture mobile integration#8700
Jonathansoufer merged 40 commits into
mainfrom
feat/snaps-integration-refactor

Conversation

@Jonathansoufer

@Jonathansoufer Jonathansoufer commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

Description

This PR adds a refactored Snaps Webview approach and embedded execution environment to allow mobile app consume the new mobile snaps architecture.

Related issues

Fixes: N/A

After Screenshot

Screen.Recording.2024-02-23.at.14.56.20.mov

Manual testing steps

  1. Open the mobile app
  2. Navigate to explore session and access snaps example page
  3. add any snap
  4. go to snaps item on settings
  5. check if the installed snap is listed.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

CI Related Section: DO NOT EDIT

Flag used by Bitrise to either run or skip E2E smoke tests

  • Bitrise Flag:[skip ci]

JSoufer and others added 30 commits February 15, 2024 12:49
bump: snaps rpc & utils, adds sdk
447fe53
chore: refactor methods usages due bumped packages
89c1cb2
chore: bump snaps-controller package
ed4ba93
chore: changing methods imports
dd2ebe0
chore: bump post-message-stream package + patching
6e53131
chore: bump @metamask/base-controller
689874e
chore: resolve conflicts
54d950c
@owencraston
bump: snaps rpc & utils, adds sdk
2d16f56
@owencraston
chore: refactor methods usages due bumped packages
50f9ac6
@owencraston
chore: bump snaps-controller package
ae042ae
@owencraston
chore: changing methods imports
e972553
@owencraston
chore: bump post-message-stream package + patching
1792a18
@owencraston
chore: bump @metamask/base-controller
4276131
@owencraston
yarn dedupe
9f2260b
@owencraston
fix specifications.test.js
00ab85f
@Jonathansoufer
Merge branch 'main' into feat/bump-mobile-snaps-packages
c99d0ed
chore: resolve conflicts
920d70d
chore: resolve conflicts on yarn.lock
60121f5
chore: fix test match with snaps codefence
55ada1b
chore: adds unencryptedSnapStates state
939e1f3
chore: fix lint problems on Engine mod
f34423d
@Jonathansoufer
Merge branch 'main' into feat/bump-mobile-snaps-packages
e1e234b
fix: endownments imports
cccda48
Merge branch 'feat/bump-mobile-snaps-packages' of github.com:MetaMask…
d912f25 
…/metamask-mobile into feat/bump-mobile-snaps-packages
chore: handle type mismatching due base-controller type change
81e2d18
@Jonathansoufer
Merge branch 'main' into feat/bump-mobile-snaps-packages
e23697d
chore: adds explicity on getRestricted type due issue core/issues/3648
d3a1dc7
Merge branch 'feat/bump-mobile-snaps-packages' of github.com:MetaMask…
2faa3ce 
…/metamask-mobile into feat/bump-mobile-snaps-packages
chore: replicates 8369 PR from branched 8607 PR
2ca518b
chore: adds addSubjectMetadata action
54234d2
@github-actions

github-actions Bot commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 23, 2024
@socket-security

socket-security Bot commented Feb 23, 2024 •
edited
Loading

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/permission-controller@7.1.0 Transitive: environment, filesystem, network +72 14.2 MB metamaskbot

🚮 Removed packages: npm/@metamask/permission-controller@4.1.2, npm/@types/readable-stream@4.0.9

View full report↗︎

@socket-security

socket-security Bot commented Feb 23, 2024 •
edited
Loading

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@codecov-commenter

codecov-commenter commented Feb 23, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 41.60%. Comparing base (e9a1442) to head (0aa92f5).

Files Patch % Lines
app/lib/snaps/SnapsExecutionWebView.tsx 27.77% 13 Missing ⚠️
app/core/Engine.ts 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8700      +/-   ##
==========================================
+ Coverage   41.54%   41.60%   +0.06%     
==========================================
  Files        1268     1263       -5     
  Lines       30664    30625      -39     
  Branches     3011     3011              
==========================================
+ Hits        12738    12741       +3     
+ Misses      17172    17130      -42     
  Partials      754      754

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

owencraston
owencraston reviewed Feb 23, 2024
View reviewed changes
Comment thread app/core/Engine.ts Outdated
owencraston
owencraston reviewed Feb 23, 2024
View reviewed changes
Comment thread app/core/Engine.ts
owencraston
owencraston reviewed Feb 23, 2024
View reviewed changes
Comment thread patches/@metamask+base-controller+4.1.1.patch
owencraston
owencraston reviewed Feb 23, 2024
View reviewed changes
Comment thread app/lib/snaps/SnapsExecutionWebView.tsx
Jonathansoufer
Jonathansoufer commented Feb 23, 2024
View reviewed changes

@Jonathansoufer Jonathansoufer left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed.

Comment thread app/core/Engine.ts Outdated
Comment thread patches/@metamask+base-controller+4.1.1.patch
Comment thread app/core/Engine.ts
@sonarqubecloud

sonarqubecloud Bot commented Feb 27, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
31.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jonathansoufer Jonathansoufer merged commit 442d9ee into main Feb 27, 2024
@Jonathansoufer Jonathansoufer deleted the feat/snaps-integration-refactor branch February 27, 2024 00:48
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 27, 2024
FrederikBolding
FrederikBolding reviewed Feb 27, 2024
View reviewed changes
Comment thread app/core/Engine.ts
FrederikBolding
FrederikBolding reviewed Feb 27, 2024
View reviewed changes
Comment thread app/core/Engine.ts
FrederikBolding
FrederikBolding reviewed Feb 27, 2024
View reviewed changes
Comment thread app/lib/snaps/SnapsExecutionWebView.tsx
Jonathansoufer
Jonathansoufer commented Feb 27, 2024
View reviewed changes

@Jonathansoufer Jonathansoufer left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed on the following PR

Comment thread app/core/Engine.ts
Comment thread app/core/Engine.ts
Comment thread app/lib/snaps/SnapsExecutionWebView.tsx
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding left review comments

@owencraston owencraston owencraston approved these changes

Assignees

@Jonathansoufer Jonathansoufer

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template mobile-snaps release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jonathansoufer @codecov-commenter @FrederikBolding @owencraston @metamaskbot