fix: removes addSubjectMetadata and improves Snaps Execution Environment Webview origin restriction.#8751
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8751 +/- ##
==========================================
+ Coverage 41.38% 41.42% +0.03%
==========================================
Files 1266 1270 +4
Lines 30768 30819 +51
Branches 3028 3041 +13
==========================================
+ Hits 12733 12766 +33
- Misses 17275 17290 +15
- Partials 760 763 +3 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Feb 28, 2024
NicolasMassart
approved these changes
Mar 20, 2024
NicolasMassart
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR address removal of subjectMetadata in favor of SnapController triggering addSubjectMetadata itself now, and adding a more restrictive originWhiteList on Snaps Execution Environment Webview.
Related issues
Fixes: Comments on the closed PR 8700
Manual testing steps
Screenshots/Recordings
After
Screen.Recording.2024-02-27.at.15.10.34.mov
Pre-merge author checklist
Pre-merge reviewer checklist